doc: improve randomfill and fix broken link #12541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
evanlucas
approved these changes
Apr 20, 2017
| @@ -2213,7 +2213,7 @@ the `crypto`, `tls`, and `https` modules and are generally specific to OpenSSL. | |||
| [`crypto.getHashes()`]: #crypto_crypto_gethashes | |||
| [`crypto.pbkdf2()`]: #crypto_crypto_pbkdf2_password_salt_iterations_keylen_digest_callback | |||
| [`crypto.randomBytes()`]: #crypto_crypto_randombytes_size_callback | |||
| [`crypto.randomFill()`]: #crypto_crypto_randombytesbuffer_buf_size_offset_cb | |||
There was a problem hiding this comment.
oh wow, thanks for fixing :]
There was a problem hiding this comment.
Got your back Jack ;-)
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`.
thefourtheye
force-pushed
the
doc-fix-randomfill
branch
from
1d806ea
to
29c4533
Compare
jasnell
approved these changes
Apr 20, 2017
cjihrig
approved these changes
Apr 20, 2017
vsemozhetbyt
approved these changes
Apr 20, 2017
lpinca
approved these changes
Apr 21, 2017
jasnell
pushed a commit
that referenced
this pull request
Apr 24, 2017
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`. PR-URL: #12541 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 95ab006 |
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`. PR-URL: #12541 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`. PR-URL: #12541 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Should land with #10209 ( |
3 tasks
4 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2018
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`. PR-URL: #12541 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 17, 2018
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`. PR-URL: #12541 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`. PR-URL: #12541 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
This patch replaces the word `buf` with `buffer` and fixes the broken link to `randomfill`. PR-URL: #12541 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces the word
bufwithbufferand fixes the brokenlink to
randomfill.Checklist
Affected core subsystem(s)
doc crypo
cc @evanlucas