test: set benchmark-child-process flaky on windows #12561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequential/test-benchmark-child-process is still failing sometimes flaky on Windows in CI. Mark it as flaky in sequential.status until it gets sorted. Refs: nodejs#12560
Trott
added
benchmark
thefourtheye
approved these changes
Apr 21, 2017
|
Looks like I lucked out and got a flaky failure on the first try, which shows the results coming back yellow as expected instead of red. I'd like to land as soon as possible so we can get rid of the red CI we've been seeing a lot of. Can I get a second on that from another Collaborator? |
danbev
approved these changes
Apr 21, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 21, 2017
sequential/test-benchmark-child-process is still failing sometimes flaky on Windows in CI. Mark it as flaky in sequential.status until it gets sorted. PR-URL: nodejs#12561 Ref: nodejs#12560 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
|
Landed in b485813 |
evanlucas
pushed a commit
that referenced
this pull request
Apr 25, 2017
sequential/test-benchmark-child-process is still failing sometimes flaky on Windows in CI. Mark it as flaky in sequential.status until it gets sorted. PR-URL: #12561 Ref: #12560 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
sequential/test-benchmark-child-process is still failing sometimes flaky on Windows in CI. Mark it as flaky in sequential.status until it gets sorted. PR-URL: #12561 Ref: #12560 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
sequential/test-benchmark-child-process is still failing sometimes flaky on Windows in CI. Mark it as flaky in sequential.status until it gets sorted. PR-URL: #12561 Ref: #12560 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
3 tasks
gibfahn
added
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sequential/test-benchmark-child-process is still failing sometimes flaky
on Windows in CI. Mark it as flaky in sequential.status until it gets
sorted.
Refs: #12560
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test child_process benchmark