Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: remove obsolete _debug_agent.js #12582

Closed
wants to merge 1 commit into from
Closed

debugger: remove obsolete _debug_agent.js #12582

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 22, 2017

With _debugger.js removed, _debug_agent.js appears to be unnecessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

debugger test

@Trott
debugger: remove obsolete _debug_agent.js
3e721a5 
With _debugger.js removed, _debug_agent.js appears to be unnecessary.
@Trott Trott added the debugger label Apr 22, 2017
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. debugger labels Apr 22, 2017
@Trott Trott added dont-land-on-v4.x semver-major PRs that contain breaking changes and should be released in the next major version. labels Apr 22, 2017
@Trott Trott added this to the 8.0.0 milestone Apr 22, 2017
@Trott
Copy link
Member Author

Trott commented Apr 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7584/

@Trott
Copy link
Member Author

Trott commented Apr 22, 2017

Assuming I'm not wrong about this being removable, there's probably some related C++ code that can go as well.

@mscdex mscdex removed the build Issues and PRs related to build files or the CI. label Apr 22, 2017
benjamingr
benjamingr approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, change seems good.

bnoordhuis
bnoordhuis approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

there's probably some related C++ code that can go as well.

I was going to look at that next week; there is quite a bit of code that can be deleted. Doesn't need to hold up this PR though.

addaleax
addaleax approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green 🎉

jasnell pushed a commit that referenced this pull request Apr 24, 2017
@Trott @jasnell
debugger: remove obsolete _debug_agent.js
549e81b 
With _debugger.js removed, _debug_agent.js appears to be unnecessary.

PR-URL: #12582
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 24, 2017

Landed in 549e81b

@jasnell jasnell closed this Apr 24, 2017
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@JacksonTian JacksonTian mentioned this pull request Jun 18, 2017
Closed
2 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
@Trott Trott deleted the remove-debug-agent branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @jasnell @bnoordhuis @addaleax @benjamingr @cjihrig @gibfahn @mscdex @nodejs-github-bot