Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-process-chdir #12589

Closed
wants to merge 1 commit into from
Closed

test: improve test-process-chdir #12589

wants to merge 1 commit into from

Conversation

vperezma
Copy link
Contributor

@vperezma vperezma commented Apr 22, 2017 •
edited by Fishrock123
Loading

remove typeError constructor and replace with regex string to match typeError message

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@vperezma
test: improve test-process-chdir
ef03f4e 
remove typeError constructor and replace with regex string to match typeError message
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 22, 2017
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/7589/

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Apr 22, 2017
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 22, 2017
addaleax
addaleax approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, I’d say you can also remove the 'Bad argument.' parameters, the error message check should be enough :)

Looks good either way, though.

Trott
Trott approved these changes Apr 22, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green. Agree with @addaleax that the third argument can optionally be removed (here or in a subsequent PR).

jasnell
jasnell approved these changes Apr 24, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This could be improved slightly by defining the regex once...

const errCheck = /^TypeError: Bad argument$/;
// ...
assert.throws(() => {}, errCheck);
assert.throws(() => {}, errCheck);

jasnell pushed a commit that referenced this pull request Apr 24, 2017
@vperezma @jasnell
test: improve test-process-chdir
b968d58 
remove typeError constructor and replace with regex string
to match typeError message

PR-URL: #12589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 24, 2017

Landed in b968d58. Thank you!

@jasnell jasnell closed this Apr 24, 2017
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@vperezma @evanlucas
test: improve test-process-chdir
2c1472c 
remove typeError constructor and replace with regex string
to match typeError message

PR-URL: #12589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@vperezma @evanlucas
test: improve test-process-chdir
da1bdd6 
remove typeError constructor and replace with regex string
to match typeError message

PR-URL: #12589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@vperezma @evanlucas
test: improve test-process-chdir
1a4bf43 
remove typeError constructor and replace with regex string
to match typeError message

PR-URL: #12589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@vperezma @gibfahn
test: improve test-process-chdir
de61346 
remove typeError constructor and replace with regex string
to match typeError message

PR-URL: #12589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@vperezma @MylesBorins
test: improve test-process-chdir
32f905a 
remove typeError constructor and replace with regex string
to match typeError message

PR-URL: #12589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@vperezma @andrew749
test: improve test-process-chdir
d1ee006 
remove typeError constructor and replace with regex string
to match typeError message

PR-URL: nodejs/node#12589
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@vperezma @vsemozhetbyt @jasnell @Trott @addaleax @cjihrig @DavidCai1111 @gibfahn @mscdex @nodejs-github-bot