Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding mustCall in test-timers-clearImmediate.js #12598

Closed
wants to merge 4 commits into from
Closed

test: adding mustCall in test-timers-clearImmediate.js #12598

wants to merge 4 commits into from

Conversation

Zahidul-Islam
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 22, 2017
@mscdex mscdex added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Apr 22, 2017
mscdex
mscdex reviewed Apr 22, 2017
View reviewed changes
test/parallel/test-timers-clearImmediate.js Outdated
clearImmediate(immediate);
++count;
});
}, 3));
Copy link
Contributor

@mscdex mscdex Apr 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just use N here instead. I think we just need common.mustCall() without a second argument when the loop below is kept.

mscdex
mscdex reviewed Apr 22, 2017
View reviewed changes
test/parallel/test-timers-clearImmediate.js Outdated
}
for (let i = 0; i < N; ++i)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this loop is still needed?

cjihrig
cjihrig requested changes Apr 22, 2017
View reviewed changes
test/parallel/test-timers-clearImmediate.js Outdated
}
for (let i = 0; i < N; ++i)
next();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test even do anything without this loop?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the below code work? It doesn't complain when I run test.

'use strict';
const common = require('../common');
const assert = require('assert');

const N = 3;
let count = 0;
function next() {
  const immediate = setImmediate(common.mustCall(() => {
    clearImmediate(immediate);
    ++count;
  }));
}

for(let i = 0; i < N; i++) {
  next();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't complain, that means the test is passing (or possibly not even doing anything). I think you should:

  1. Put the for loop back.
  2. Remove the count variable.
  3. Drop the second argument to common.mustCall() as @mscdex said.

@Zahidul-Islam
Copy link
Author

@cjihrig I have updated my commit.

@mscdex
Copy link
Contributor

mscdex commented Apr 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7597/

cjihrig
cjihrig approved these changes Apr 22, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once it passes CI. You look to have some linting errors though. Try running make lint locally.

@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 22, 2017
@Zahidul-Islam
Copy link
Author

@cjihrig I have fixed lint error.

@mscdex
Copy link
Contributor

mscdex commented Apr 22, 2017

New CI: https://ci.nodejs.org/job/node-test-pull-request/7604/

@Trott
Copy link
Member

Trott commented Apr 23, 2017

Linux CI issues are build/infrastructure issues and nothing to do with the changes here. CI looks good.

Fishrock123
Fishrock123 reviewed Apr 24, 2017
View reviewed changes
test/parallel/test-timers-clearImmediate.js
});
const immediate = setImmediate(
common.mustCall(() => clearImmediate(immediate))
);
Copy link
Contributor

@Fishrock123 Fishrock123 Apr 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this indentation off?

jasnell
jasnell approved these changes Apr 24, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with linting errors fixed

Trott pushed a commit to Trott/io.js that referenced this pull request Apr 26, 2017
@ChatbotSchool @Trott
test: add mustCall in test-timers-clearImmediate
c405497 
PR-URL: nodejs#12598
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Apr 26, 2017

Landed in c405497.
Thanks for the contribution! 🎉

@Trott Trott closed this Apr 26, 2017
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@ChatbotSchool @evanlucas
test: add mustCall in test-timers-clearImmediate
b3f0c5a 
PR-URL: #12598
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@ChatbotSchool @evanlucas
test: add mustCall in test-timers-clearImmediate
29641c8 
PR-URL: #12598
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@ChatbotSchool @evanlucas
test: add mustCall in test-timers-clearImmediate
d15b1c4 
PR-URL: #12598
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@ChatbotSchool @gibfahn
test: add mustCall in test-timers-clearImmediate
4e8399f 
PR-URL: #12598
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@ChatbotSchool @MylesBorins
test: add mustCall in test-timers-clearImmediate
3cce181 
PR-URL: #12598
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@ChatbotSchool @andrew749
test: add mustCall in test-timers-clearImmediate
82d747c 
PR-URL: nodejs/node#12598
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 left review comments

@mscdex mscdex mscdex left review comments

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.