test: improve test-tcp-wrap-listen #12599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SIngle CI failure is build/infrastructure related, not related to this change. So CI looks good. |
santigimeno
reviewed
Apr 24, 2017
| maybeCloseClient(); | ||
| } | ||
| }; | ||
| }, 2); |
There was a problem hiding this comment.
Probably will never happen but this could be called more than twice.
santigimeno
reviewed
Apr 24, 2017
| assert.strictEqual('hello world', d); | ||
| recvCount++; | ||
| }); | ||
| })); |
There was a problem hiding this comment.
Same here, though highly unlikely, this could be called more than once
jasnell
added
the
code-and-learn
jasnell
approved these changes
Apr 24, 2017
|
Landed in 7c238be @santigimeno I think if the behaviour here was actually non-deterministic enough to fail in CI, that would already have been happening. This PR just refactors it for readability, I don’t think it should actually change its behaviour. |
addaleax
pushed a commit
that referenced
this pull request
Apr 29, 2017
PR-URL: #12599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas
pushed a commit
that referenced
this pull request
May 3, 2017
PR-URL: #12599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Doesn't land on 6.x, @alohaglenn do you want to backport? |
MylesBorins
pushed a commit
that referenced
this pull request
May 15, 2017
PR-URL: #12599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
got this landing cleanly. Thanks c304414 |
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#12599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)