test: support unreleased V8 versions #12619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the RegExp in test-process-versions so that the test can pass with V8 versions that have no patch number.
|
This is required to make the tests pass on the |
vsemozhetbyt
approved these changes
Apr 24, 2017
cjihrig
approved these changes
Apr 24, 2017
richardlau
approved these changes
Apr 24, 2017
gibfahn
approved these changes
Apr 24, 2017
jasnell
approved these changes
Apr 24, 2017
|
FreeBSD failure is unrelated. |
targos
added a commit
that referenced
this pull request
Apr 26, 2017
Change the RegExp in test-process-versions so that the test can pass with V8 versions that have no patch number. PR-URL: #12619 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
|
Depends on #12464 which is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the RegExp in test-process-versions so that the test can pass
with V8 versions that have no patch number.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, V8