Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: modernize and fix code examples in readline.md #12634

Closed
wants to merge 2 commits into from
Closed

doc: modernize and fix code examples in readline.md #12634

wants to merge 2 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, readline

  • Improve UX in 2 code examples (add spaces between output and input for better readability).
  • Replace indexOf() by startsWith().

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Apr 24, 2017
@vsemozhetbyt
Copy link
Contributor Author

@vsemozhetbyt
Copy link
Contributor Author

Rebased to test new linter CI: https://ci.nodejs.org/job/node-test-linter/8560/

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vsemozhetbyt added a commit that referenced this pull request Apr 26, 2017
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 35d2137

@vsemozhetbyt vsemozhetbyt deleted the readline.md branch April 26, 2017 22:48
@vsemozhetbyt
Copy link
Contributor Author

Oops. Sorry, typo in the commit message: repl.md should be readline.md. It is late to force push :( I hope this will not cause much confusing.

@jasnell jasnell mentioned this pull request May 11, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 18, 2017
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
* Improve UX in 2 code examples (add spaces between output and input
  for better readability).

* Replace indexOf() by startsWith().

PR-URL: #12634
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants