v8: fix gcc 7 build errors #12676
Closed
v8: fix gcc 7 build errors #12676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
addaleax
approved these changes
Apr 26, 2017
|
/cc @nodejs/v8 |
mscdex
added
build
bnoordhuis
approved these changes
Apr 28, 2017
|
The previous CI 404s (it might be because the CI was reset?), new attempt: https://ci.nodejs.org/job/node-test-commit/9506/ |
|
The ARM failures might be related, trying again to be sure: https://ci.nodejs.org/job/node-test-commit-arm-fanned/8371/ (edit: green) |
|
Landed in b07e1a8, thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Apr 29, 2017
targos
pushed a commit
to targos/node
that referenced
this pull request
May 6, 2017
Porting nodejs#12392 to master Ref: nodejs#12392 Fixes: nodejs#10388 PR-URL: nodejs#12676 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
May 6, 2017
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
Porting nodejs#12392 to master Ref: nodejs#12392 Fixes: nodejs#10388 PR-URL: nodejs#12676 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
3 tasks
|
This was backported to v6.x in #13574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #12392 to master
Fixes: #10388
make -j4 test(UNIX)While trying to build latest v8.0.0-nightly on Fedora rawhide with gcc 7.0.1 I encountered some errors, so I'm opening this PR against master.