Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix examples in repl.md #12684

Closed
wants to merge 1 commit into from
Closed

doc: fix examples in repl.md #12684

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, repl

  • Update an example according to an actual REPL session.
  • Replace an arrow function with a common function to hold this.

* Update an example according to an actual REPL session.

* Replace an arrow function with a common function to hold `this`.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Apr 27, 2017
@vsemozhetbyt
Copy link
Contributor Author

@vsemozhetbyt
Copy link
Contributor Author

Landed in 8092fb0

@vsemozhetbyt vsemozhetbyt deleted the repl.md branch April 28, 2017 23:09
vsemozhetbyt added a commit that referenced this pull request Apr 28, 2017
* Update an example according to an actual REPL session.
* Replace an arrow function with a common function to hold `this`.

PR-URL: #12684
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request May 1, 2017
evanlucas pushed a commit that referenced this pull request May 1, 2017
* Update an example according to an actual REPL session.
* Replace an arrow function with a common function to hold `this`.

PR-URL: #12684
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
* Update an example according to an actual REPL session.
* Replace an arrow function with a common function to hold `this`.

PR-URL: #12684
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
* Update an example according to an actual REPL session.
* Replace an arrow function with a common function to hold `this`.

PR-URL: #12684
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request May 3, 2017
* Update an example according to an actual REPL session.
* Replace an arrow function with a common function to hold `this`.

PR-URL: #12684
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

So it seems like we don't have a note that the example found at https://github.com/nodejs/node/blob/8092fb0a59927159ec68c914771c6be484116203/doc/api/repl.md#replserverdefinecommandkeyword-cmd should not be run in the repl. Should we open an issue about this? Good first PR 😄

@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented May 15, 2017

It seems this PR can be ignored in v6: its doc has not changes that had made those examples erroneous,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants