-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: fix incorrect macro comment #12688
Conversation
Commit de168b4 ("src: guard bundled_ca/openssl_ca with HAVE_OPENSSL") included an incorrect end macro comment which this commit fixes.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This doesn't need to wait to land.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not need to wait the 48 hours to land
heh... just saw that @cjihrig said the same thing :-) |
Commit de168b4 ("src: guard bundled_ca/openssl_ca with HAVE_OPENSSL") included an incorrect end macro comment which this commit fixes. PR-URL: nodejs#12688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 892ce06 |
Depends on #12302 |
Commit de168b4 ("src: guard bundled_ca/openssl_ca with HAVE_OPENSSL") included an incorrect end macro comment which this commit fixes. PR-URL: #12688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Commit de168b4 ("src: guard bundled_ca/openssl_ca with HAVE_OPENSSL") included an incorrect end macro comment which this commit fixes. PR-URL: #12688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Commit de168b4 ("src: guard bundled_ca/openssl_ca with HAVE_OPENSSL") included an incorrect end macro comment which this commit fixes. PR-URL: #12688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Commit de168b4 ("src: guard bundled_ca/openssl_ca with HAVE_OPENSSL") included an incorrect end macro comment which this commit fixes. PR-URL: #12688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Commit de168b4 ("src: guard bundled_ca/openssl_ca with HAVE_OPENSSL") included an incorrect end macro comment which this commit fixes. PR-URL: #12688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Commit de168b4 ("src: guard
bundled_ca/openssl_ca with HAVE_OPENSSL") included an incorrect end
macro comment which this commit fixes.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
src