modified test-repl-persistent-history to use common.mustCall #12703
Conversation
| @@ -212,7 +206,10 @@ function cleanupTmpFile() { | |||
|
|
|||
| // Copy our fixture to the tmp directory | |||
| fs.createReadStream(historyFixturePath) | |||
| .pipe(fs.createWriteStream(historyPath)).on('unpipe', () => runTest()); | |||
| .pipe(fs.createWriteStream(historyPath)).on('unpipe', runTest); | |||
There was a problem hiding this comment.
Could you leave this as it was please.
There was a problem hiding this comment.
I'll do so. I removed the function because this way runTest was accounting for an additional call. I thought it'd be an extra burden on the reader if he sees common.mustCall(runTest, numtests + 1) later on. Sorry, this was my first contribution on the git via NodeTodo, I am figuring out how to undo these changes as recommended.
| .pipe(fs.createWriteStream(historyPath)).on('unpipe', () => runTest()); | ||
| .pipe(fs.createWriteStream(historyPath)).on('unpipe', runTest); | ||
|
|
||
| // redefine runTest function that uses common.mustCall (https://github.com/nodejs/node/tree/master/test#mustcallfn-expected) |
There was a problem hiding this comment.
This comment can be dropped.
| .pipe(fs.createWriteStream(historyPath)).on('unpipe', runTest); | ||
|
|
||
| // redefine runTest function that uses common.mustCall (https://github.com/nodejs/node/tree/master/test#mustcallfn-expected) | ||
| runTest = common.mustCall(runTest, numtests); |
There was a problem hiding this comment.
Could you please name the wrapped version something else and update the call points respectively?
There was a problem hiding this comment.
Can you please look at it now? Thank you. I hope it was Ok to --amend this change?
There was a problem hiding this comment.
I hope it was Ok to --amend this change?
Yeah that's fine
cool88
force-pushed
the
master
branch
2 times, most recently
from
9549df3
to
ef63593
Compare
|
This LGTM if CI is green. Ping @cjihrig @Fishrock123 |
|
Landed in 6058c43, thanks for the PR! :) |
PR-URL: #12703 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#12703 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #12703 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #12703 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)