Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove common.PORT in test tls ticket cluster #12715

Closed
wants to merge 1 commit into from
Closed

test: remove common.PORT in test tls ticket cluster #12715

wants to merge 1 commit into from

Conversation

ooHmartY
Copy link
Contributor

Updating tests to remove common.PORT per issue #12376

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2017
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Apr 28, 2017
cjihrig
cjihrig approved these changes May 1, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes

@santigimeno
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7883/

@addaleax
Copy link
Member

addaleax commented May 7, 2017

Landed in dac9f42, thanks for the PR! :)

@addaleax addaleax closed this May 7, 2017
addaleax pushed a commit that referenced this pull request May 7, 2017
@ooHmartY @addaleax
test: remove common.PORT in test tls ticket cluster
dac9f42 
PR-URL: #12715
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@ooHmartY
test: remove common.PORT in test tls ticket cluster
1c53140 
PR-URL: nodejs#12715
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@ooHmartY @gibfahn
test: remove common.PORT in test tls ticket cluster
6b50a92 
PR-URL: #12715
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@ooHmartY @MylesBorins
test: remove common.PORT in test tls ticket cluster
aaf8044 
PR-URL: #12715
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
Open
@aliscco aliscco mentioned this pull request Dec 25, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Jan 3, 2024
Open
@leonardoadame leonardoadame mentioned this pull request May 13, 2024
Open
This was referenced May 14, 2024
Open
Open
@leonardoadame leonardoadame mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ooHmartY @santigimeno @addaleax @cjihrig @mscdex @gibfahn @nodejs-github-bot