-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: sort bottom-of-file markdown links #12726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ci: https://ci.nodejs.org/job/node-test-pull-request/7732/ (because you never know) |
cjihrig
approved these changes
Apr 28, 2017
jasnell
approved these changes
Apr 28, 2017
lpinca
approved these changes
May 2, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM
gibfahn
approved these changes
May 5, 2017
@sam-github Can you rebase? :) |
sam-github
force-pushed
the
sort-markdown-links
branch
from
May 8, 2017 16:30
4f942d7
to
5ba941f
Compare
PR-URL: nodejs#12726 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
sam-github
force-pushed
the
sort-markdown-links
branch
from
May 8, 2017 16:31
5ba941f
to
ea1b8a5
Compare
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
PR-URL: nodejs#12726 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
3 tasks
Marking as don't land because it has a bajillion conflicts, feel free to backport if you want to though. |
2 tasks
1 task
4 tasks
sam-github
added a commit
to sam-github/node
that referenced
this pull request
Nov 28, 2018
Reapply nodejs#12726 It would be nice to have the sort check applied as part of doc testing, but this change doesn't implement that.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 28, 2018
Reapply nodejs#12726 It would be nice to have the sort check applied as part of doc testing, but this change doesn't implement that. PR-URL: nodejs#24679 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Reapply nodejs#12726 It would be nice to have the sort check applied as part of doc testing, but this change doesn't implement that. PR-URL: nodejs#24679 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc