Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix warning in n-api reference test #12730

Closed
wants to merge 2 commits into from
Closed

test: fix warning in n-api reference test #12730

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5daef8
test: fix warning in n-api reference test
mhdawson Apr 28, 2017
4711d13
squash: address first set of comments
mhdawson May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/addons-napi/test_reference/test_reference.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ napi_value CheckExternal(napi_env env, napi_callback_info info) {
NAPI_ASSERT(env, argtype == napi_external, "Expected an external value.")

int* data;
NAPI_CALL(env, napi_get_value_external(env, arg, &data));
NAPI_CALL(env, napi_get_value_external(env, arg, (void*)&data));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be void**, not void*. Alternatively, you could also lose the pointer-to-pointer cast and do it the safe way:

void* data;
napi_get_value_external(env, arg, &data);
data != NULL && *(int*)data == test_value


NAPI_ASSERT(env, data != NULL && *data == test_value,
"An external data value of 1 was expected.")
Expand Down