test: reduce sequential/test-fs-watch flakiness #1275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. It doesn't fix it reliably (there is a benign race with the fsevents thread going on) but it's good enough as a bandaid. CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/381/ |
silverwind
added a commit
that referenced
this pull request
Mar 27, 2015
The fs.watch test's write events sometimes aren't produced on OS X, possibly because of a fsevents race condition. This patch gives delays the writing a total of 20ms, which makes the test pass consistently. PR-URL: #1275 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
merged in 955c150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that
fs.watchis sometimes unable to produce watcher events on OS X in the current 10ms timeframe, leading to the test completely timing out. My tests show that 15ms seems to eliminate most of these failures, but I opted to go for 20ms to be on the safe side.This is probably hardware dependent, and my tests were done on a 2013 MBA. CI was affected too sometimes.