-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: turn buffer type-CHECK into exception #12753
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
Apr 29, 2017
refack
approved these changes
Apr 30, 2017
TimothyGu
approved these changes
Apr 30, 2017
cjihrig
approved these changes
Apr 30, 2017
jasnell
approved these changes
May 1, 2017
addaleax
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
and removed
stream
Issues and PRs related to the stream subsystem.
labels
May 3, 2017
Turn a `CHECK()` that could be brought to fail using public APIs into throwing an error. Fixes: nodejs#12152
addaleax
force-pushed
the
fix-type-confusion-cash-12152
branch
from
May 3, 2017 13:47
753a650
to
a9e1bba
Compare
Had to fix up the test because it previously depended on the type of |
|
refack
approved these changes
May 3, 2017
|
Landed in 9990be2 |
addaleax
added a commit
that referenced
this pull request
May 3, 2017
Turn a `CHECK()` that could be brought to fail using public APIs into throwing an error. Fixes: #12152 PR-URL: #12753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
Turn a `CHECK()` that could be brought to fail using public APIs into throwing an error. Fixes: nodejs#12152 PR-URL: nodejs#12753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
3 tasks
@addaleax should this be backported? |
@gibfahn Yes. |
gibfahn
pushed a commit
that referenced
this pull request
Jun 18, 2017
Turn a `CHECK()` that could be brought to fail using public APIs into throwing an error. Fixes: #12152 PR-URL: #12753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
Turn a `CHECK()` that could be brought to fail using public APIs into throwing an error. Fixes: #12152 PR-URL: #12753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
Turn a `CHECK()` that could be brought to fail using public APIs into throwing an error. Fixes: #12152 PR-URL: #12753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn a
CHECK()
that could be brought to fail using public APIsinto throwing an error.
Fixes: #12152
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
stream_base