Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: do proper StringBytes error handling #12765

Closed
wants to merge 4 commits into from
Closed

src: do proper StringBytes error handling #12765

wants to merge 4 commits into from

Commits on May 1, 2017

  1. src: do proper StringBytes error handling 

    - Return `MaybeLocal`s from `StringBytes::Encode`
- Add an `error` out parameter to pass JS exceptions to the callers
  (instead of directly throwing)
- Simplify some of the string generation methods in `string_bytes.cc`
  by unifying the `EXTERN_APEX` logic
- Reduce usage of deprecated V8 APIs.
- Remove error handling logic from JS, the `buffer.*Slice()` methods
  now throw errors themselves.
- Left TODO comments for future semver-major error message
  improvements.

This paves the way for better error messages coming out of the
StringBytes methods.

Ref: nodejs#3175
    @addaleax
    addaleax committed May 1, 2017
    Configuration menu
    Copy the full SHA
    0aff46e View commit details
    Browse the repository at this point in the history

  2. [squash] throw errors for crypto return

    @addaleax
    addaleax committed May 1, 2017
    Configuration menu
    Copy the full SHA
    2ea112b View commit details
    Browse the repository at this point in the history

  3. [squash] remove goto → inline error statements

    @addaleax
    addaleax committed May 1, 2017
    Configuration menu
    Copy the full SHA
    a65a5c3 View commit details
    Browse the repository at this point in the history

  4. [squash] remove indentation for the fast case

    @addaleax
    addaleax committed May 1, 2017
    Configuration menu
    Copy the full SHA
    389af5a View commit details
    Browse the repository at this point in the history