Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: remove unnecessary parameter #12767

Closed
wants to merge 1 commit into from
Closed

stream: remove unnecessary parameter #12767

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Delete invalid parameter.

Fixes: #8153

Patch taken straight from the issue, I’ve only edited the title.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

streams

@addaleax
stream: remove unnecessary parameter
5b4c475 
Delete invalid parameter.

Fixes: nodejs#8153
@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Apr 30, 2017
@DavidCai1111
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/7769/

@mscdex
Copy link
Contributor

mscdex commented May 1, 2017

LGTM

@addaleax
Copy link
Member Author

addaleax commented May 3, 2017

Landed in d6a6bcd

@addaleax addaleax closed this May 3, 2017
@addaleax addaleax deleted the streams-extra-param branch May 3, 2017 13:19
addaleax pushed a commit that referenced this pull request May 3, 2017
@addaleax
stream: remove unnecessary parameter
d6a6bcd 
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
stream: remove unnecessary parameter
61a8ea3 
Delete invalid parameter.

Fixes: nodejs#8153
PR-URL: nodejs#12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 18, 2017
@gibfahn
stream: remove unnecessary parameter
2532fb4 
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn
Copy link
Member

gibfahn commented Jun 18, 2017

Landed on 6.x, LMK if that was a mistake.

gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@gibfahn
stream: remove unnecessary parameter
975ef87 
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@MylesBorins
stream: remove unnecessary parameter
48a923a 
Delete invalid parameter.

Fixes: #8153
PR-URL: #12767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @DavidCai1111 @mscdex @gibfahn @jasnell @lpinca @cjihrig @nodejs-github-bot