test: enable test-debugger-pid

[Trott]

Now that node debug is an alias for node inspect, it's possible that
node-debug-pid can run reliably. Modify for current behavior and move
from disabled to parallel.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test debugger inspector

[Trott]

Labeled as in progress pending CI results as I'm not able to run on Windows etc. locally.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/7765/

[Trott]

Hmmm...Windows fails. A few options:

• skip the test on Windows
• bifurcated logic to handle Windows behavior
• remove the test entirely as it's mostly testing the behavior of the node-inspect dependency anyway and not Node.js core itself

Thoughts? /cc @jkrems

[Trott]

Added code to skip parts of the test on Windows.

CI: https://ci.nodejs.org/job/node-test-pull-request/7767/

Because I hope/expect this to pass CI, I'm going to remove the in progress label too...

[jkrems]

I think in the future we should investigate adding make test-node-inspect to our general CI runs. Until then having some smoke tests like this one as part of node's own test suite is definitely valuable.

[addaleax]

Linter failure:

Running JS linter...
./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.md \
  benchmark doc lib test tools

/home/xxxx/src/node/master/test/parallel/test-debugger-pid.js
  13:7  error  Expected a function declaration  func-style

✖ 1 problem (1 error, 0 warnings)

[Trott]

Rebased and adjusted to conform with new lint rule.

New CI: https://ci.nodejs.org/job/node-test-pull-request/7842/

[Trott]

Landed in 4677766