Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add comment to all whatwg-url tests saying they should not be m… #12797

Closed
wants to merge 1 commit into from
Closed

test: add comment to all whatwg-url tests saying they should not be m… #12797

wants to merge 1 commit into from

Conversation

rayto510
Copy link

@rayto510 rayto510 commented May 2, 2017

…odified

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 2, 2017
@vsemozhetbyt
Copy link
Contributor

Thank you!
CI: https://ci.nodejs.org/job/node-test-pull-request/7808/

@refack
Copy link
Contributor

refack commented May 2, 2017

@rayto510 Thank you for the contribution! 🥇
Two comments:

  1. The commit message should follow our guidelines
  2. Both the commit message and PR description should state what is the motivation for the suggesting this change

@rayto510 rayto510 closed this May 2, 2017
@refack
Copy link
Contributor

refack commented May 2, 2017

Superseded by #12798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rayto510 @vsemozhetbyt @refack @nodejs-github-bot