Revert "net: remove unnecessary process.nextTick()" #12854

evanlucas · 2017-05-05T11:18:41Z

This reverts commit 571882c.

Removing the process.nextTick() call can prevent the consumer
from being able to catch error events.

Looks like we ran into this before in af249fa

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

/cc @bnoordhuis

benjamingr · 2017-05-05T12:01:25Z

Commit description should probably note that there is no behavior change here since inernalConnect already defers callbacks.

mscdex · 2017-05-05T15:51:41Z

I wonder if it would be better to instead just use process.nextTick() if there was an immediate error while connecting to an IP address? That way we can still avoid calling process.nextTick() for the successful connection case.

jasnell

This is the second regression from this PR we've seen. We definitely may be able to take another stab at refactoring this, but a simple revert is best, I think, and we can do more later.

bnoordhuis · 2017-05-07T07:02:21Z

A regression test should be added. #2054 could (and arguably should) have done that but better late than never.

evanlucas · 2017-05-10T00:32:39Z

A regression test should be added. #2054 could (and arguably should) have done that but better late than never.

Yep, will get that updated tonight or tomorrow

evanlucas · 2017-05-11T15:23:02Z

Ok, so it looks like 503b089 added a regression test for the original issue, but only tested against net and not an http request. In this case, the http request calls this.agent.addRequest(this, options) which will then call req.onSocket(socket) which then calls onSocketNT(req, socket) which calls tickOnSocket(req, socket).

The error listener is added to the socket here which is called in process.nextTick() in onSocket(). So that is why the test added before did not catch it. I'll add an additional test for http as well.

evanlucas · 2017-05-11T15:36:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/8019/

evanlucas · 2017-05-11T19:45:09Z

Ok, so looks like this now breaks an async-hooks test

➜ ./node test/async-hooks/test-tcpwrap.js
assert.js:92
  throw new AssertionError({
  ^

AssertionError [ERR_ASSERTION]: 1 TCPCONNECTWRAP present when client is connecting
    at Object.<anonymous> (/Volumes/code/forks/node/test/async-hooks/test-tcpwrap.js:56:10)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:144:16)
    at bootstrap_node.js:561:3

Going to look more into this for the best solution

evanlucas · 2017-05-16T10:38:46Z

/cc @AndreasMadsen (since it seems to be async-hooks related) any suggestions on the error I'm now getting above with this change?

AndreasMadsen · 2017-05-16T11:04:51Z

I think it should be nextTick(self[async_id_symbol], function() { instead of process.nextTick and then some of the test counters might have to changed since it is no longer an immediate initialization.

evanlucas · 2017-05-17T12:38:43Z

ok, updated to account for async-hooks. PTAL

CI: https://ci.nodejs.org/job/node-test-pull-request/8118/

refack · 2017-05-18T23:01:23Z

I killed the CI by mistake, sorry.
New CI: https://ci.nodejs.org/job/node-test-pull-request/8166/

evanlucas · 2017-05-22T12:39:05Z

@cjihrig @jasnell @benjamingr mind taking another quick look. I added a regression test since yall approved it previously. Thanks!

CI one more time: https://ci.nodejs.org/job/node-test-pull-request/8226/

cjihrig

LGTM. A comment near the top of the test and some validation of the error object might be useful.

This reverts commit 571882c. Removing the process.nextTick() call can prevent the consumer from being able to catch error events. PR-URL: nodejs#12854 Fixes: nodejs#12841 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This test ensures that a http client request with the default agent that has a socket that is immediately destroyed can still be caught by adding an error event listener to the request object. PR-URL: nodejs#12854 Fixes: nodejs#12841 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas · 2017-05-23T18:23:18Z

Landed in ba0dbaa and 2cf4882. Thanks!

This reverts commit 571882c. Removing the process.nextTick() call can prevent the consumer from being able to catch error events. PR-URL: #12854 Fixes: #12841 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This test ensures that a http client request with the default agent that has a socket that is immediately destroyed can still be caught by adding an error event listener to the request object. PR-URL: #12854 Fixes: #12841 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This reverts commit 571882c. Removing the process.nextTick() call can prevent the consumer from being able to catch error events. PR-URL: #12854 Fixes: #12841 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

This test ensures that a http client request with the default agent that has a socket that is immediately destroyed can still be caught by adding an error event listener to the request object. PR-URL: #12854 Fixes: #12841 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

nodejs-github-bot added the net Issues and PRs related to the net subsystem. label May 5, 2017

cjihrig approved these changes May 5, 2017

View reviewed changes

evanlucas mentioned this pull request May 5, 2017

net: micro cleanups #12342

Merged

benjamingr approved these changes May 5, 2017

View reviewed changes

jasnell approved these changes May 7, 2017

View reviewed changes

evanlucas force-pushed the revertnet branch from 17a7479 to 6c77a98 Compare May 11, 2017 15:35

evanlucas force-pushed the revertnet branch from 6c77a98 to 387acc6 Compare May 16, 2017 10:39

bnoordhuis approved these changes May 17, 2017

View reviewed changes

AndreasMadsen mentioned this pull request May 17, 2017

test: investigate async-hooks/test-tcpwrap for flakiness on Linux #12997

Closed

evanlucas force-pushed the revertnet branch from 12ae751 to 8b89f3a Compare May 18, 2017 22:39

evanlucas force-pushed the revertnet branch from 3f00c89 to ca114f8 Compare May 22, 2017 12:37

cjihrig approved these changes May 22, 2017

View reviewed changes

evanlucas added 2 commits May 23, 2017 13:20

evanlucas force-pushed the revertnet branch from bc2cad6 to 2cf4882 Compare May 23, 2017 18:22

evanlucas closed this May 23, 2017

evanlucas deleted the revertnet branch May 23, 2017 18:22

evanlucas merged commit 2cf4882 into nodejs:master May 23, 2017

refack mentioned this pull request May 24, 2017

test: investigate flakiness of parallel/test-async-wrap-getasyncid #13020

Closed

jasnell mentioned this pull request May 28, 2017

8.0.0 Release Proposal #12220

Closed

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added the dont-land-on-v6.x label Jul 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "net: remove unnecessary process.nextTick()" #12854

Revert "net: remove unnecessary process.nextTick()" #12854

evanlucas commented May 5, 2017

benjamingr commented May 5, 2017

mscdex commented May 5, 2017 •

edited

Loading

jasnell left a comment

bnoordhuis commented May 7, 2017

evanlucas commented May 10, 2017

evanlucas commented May 11, 2017

evanlucas commented May 11, 2017

evanlucas commented May 11, 2017

evanlucas commented May 16, 2017

AndreasMadsen commented May 16, 2017 •

edited

Loading

evanlucas commented May 17, 2017

refack commented May 18, 2017

evanlucas commented May 22, 2017

cjihrig left a comment

evanlucas commented May 23, 2017

Revert "net: remove unnecessary process.nextTick()" #12854

Revert "net: remove unnecessary process.nextTick()" #12854

Conversation

evanlucas commented May 5, 2017

Checklist

Affected core subsystem(s)

benjamingr commented May 5, 2017

mscdex commented May 5, 2017 • edited Loading

jasnell left a comment

Choose a reason for hiding this comment

bnoordhuis commented May 7, 2017

evanlucas commented May 10, 2017

evanlucas commented May 11, 2017

evanlucas commented May 11, 2017

evanlucas commented May 11, 2017

evanlucas commented May 16, 2017

AndreasMadsen commented May 16, 2017 • edited Loading

evanlucas commented May 17, 2017

refack commented May 18, 2017

evanlucas commented May 22, 2017

cjihrig left a comment

Choose a reason for hiding this comment

evanlucas commented May 23, 2017

mscdex commented May 5, 2017 •

edited

Loading

AndreasMadsen commented May 16, 2017 •

edited

Loading