Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streams: remove all references to readableState/writableState from docs #12855

Closed

Commits on Nov 16, 2017

  1. streams: add flow and buffer properties to streams

    This adds computed properties to readable and writable streams to allow access
    to the readable buffer, the writable buffer, and flow state without accessing
    the readable or writable state.  An underscored method is also added to allow
    internal function to set the flow state.
    
    These are the only uses of readable and writable state in the docs so adding
    these work arounds allows them to be removed from the docs.
    
    Part of the readableState/writableState mega issue  nodejs#445.
    calvinmetcalf authored and mcollina committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    19e5d47 View commit details
    Browse the repository at this point in the history
  2. docs: remove readable and writable state

    This changes the docs to use the new readableBuffer, writableBuffer, and flow
    properties instead of manipulating the readable and writable state.
    
    Part of the readableState/writableState mega issue nodejs#445.
    calvinmetcalf authored and mcollina committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    5d5ea31 View commit details
    Browse the repository at this point in the history
  3. http: use new internal method to set stream flow

    This updates http_client and http_server to use the new _setFlowing method to
    set the flowing state instead of directly manipulating readable state.
    
    Part of the readableState/writableState mega issue nodejs#445.
    calvinmetcalf authored and mcollina committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    d974375 View commit details
    Browse the repository at this point in the history
  4. net: avoid 2 usages of internal stream state

    This uses the new internal method _setFlowing to avoid a manipulation
    of readable state and uses writableBuffer instead of the getBuffer method of the
    writable state.
    
    Part of the readableState/writableState mega issue  nodejs#445
    calvinmetcalf authored and mcollina committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    b3c8f34 View commit details
    Browse the repository at this point in the history
  5. squash: address doc nits

    mcollina committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    d002892 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2017

  1. Configuration menu
    Copy the full SHA
    589910a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1be5153 View commit details
    Browse the repository at this point in the history