fs: refactor deprecated functions for readability #12910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small refactor to make an object more readable (IMO). Yeah, I spent a bit longer looking at the code and misunderstanding it than I care to admit right now.
|
I understand if this gets rejected as churn, but I do feel this is more readable. Or maybe I just need more sleep. |
hiroppy
approved these changes
May 9, 2017
gibfahn
approved these changes
May 9, 2017
|
Looks cleaner to me, always in favour of readability. |
jasnell
approved these changes
May 9, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 11, 2017
This is a small refactor to make an object more readable (IMO). Yeah, I spent a bit longer looking at the code and misunderstanding it than I care to admit right now. PR-URL: nodejs#12910 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 6f449db |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
This is a small refactor to make an object more readable (IMO). Yeah, I spent a bit longer looking at the code and misunderstanding it than I care to admit right now. PR-URL: nodejs#12910 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor to make an object more readable (IMO).
Yeah, I spent a bit longer looking at the code and misunderstanding it
than I care to admit right now.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs