Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https: support agent construction without new #12927

Merged
merged 1 commit into from
May 11, 2017
Merged

https: support agent construction without new #12927

merged 1 commit into from
May 11, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 9, 2017

Fixes: #12918

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

https

@nodejs-github-bot nodejs-github-bot added the https Issues or PRs related to the https subsystem. label May 9, 2017
thefourtheye
thefourtheye approved these changes May 9, 2017
View reviewed changes
Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with HTTP Agents now. Cool.

@jasnell
Copy link
Member

jasnell commented May 9, 2017

+0 ... I understand the logic, but given the direction for ES6 Classes, I'd rather go the opposite direction on things. The code change itself LGTM but guess I'm not not enthusiastic.

lpinca
lpinca reviewed May 10, 2017
View reviewed changes
test/parallel/test-https-agent-constructor.js
const assert = require('assert');
const https = require('https');

assert.doesNotThrow(() => { https.Agent(); });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add an assertion like this?

assert.ok(https.Agent() instanceof Agent);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assertion added

@cjihrig
Copy link
Contributor Author

cjihrig commented May 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7992/

@cjihrig
https: support agent construction without new
d4dc1a1 
Fixes: nodejs#12918
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig cjihrig merged commit d4dc1a1 into nodejs:master May 11, 2017
@cjihrig cjihrig deleted the https branch May 11, 2017 19:29
@cjihrig
Copy link
Contributor Author

cjihrig commented May 11, 2017

Landed in 9ce2271.

cjihrig added a commit that referenced this pull request May 11, 2017
@cjihrig
https: support agent construction without new
9ce2271 
Fixes: #12918
PR-URL: #12927
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anchnk pushed a commit to anchnk/node that referenced this pull request May 19, 2017
@cjihrig
https: support agent construction without new
47c4d96 
Fixes: nodejs#12918
PR-URL: nodejs#12927
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins
Copy link
Contributor

Should this land in LTS? Is this considered a bug fix? If not it likely should have been semver minor

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 22, 2017

I'd consider it a bug fix.

MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@cjihrig @MylesBorins
https: support agent construction without new
d51cd61 
Fixes: #12918
PR-URL: #12927
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
MylesBorins added a commit that referenced this pull request Aug 1, 2017
@MylesBorins
2017-08-01, Version 6.11.2 'Boron' (LTS)
f15e124 
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.

Notable Changes:

* configure:
  - add mips64el to valid_arch (Aditya Anand)
    - #13620
* crypto:
  - Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
    - #13279
    - #12402
    - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
  - upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
    - #12913
* http:
  - parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
    - #13206
  - Agent construction can now be envoked without `new` (cjihrig)
    - #12927
* zlib:
  - node will now throw an Error when zlib rejects the value of windowBits,
    instead of crashing (Alexey Orlenko)
    - #13098

PR-URL: #14356
MylesBorins added a commit that referenced this pull request Aug 1, 2017
@MylesBorins
2017-08-01, Version 6.11.2 'Boron' (LTS)
8a53897 
This LTS release comes with 221 commits. This includes 80 which are
test related, 52 which are doc related, 32 which are build / tool
related and 10 commits which are updates to dependencies.

Notable Changes:

* configure:
  - add mips64el to valid_arch (Aditya Anand)
    - #13620
* crypto:
  - Updated root certificates based on [NSS 3.30] (Ben Noordhuis)
    - #13279
    - #12402
    - https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.30_release_notes
* deps:
  - upgrade OpenSSL to version 1.0.2.l (Shigeki Ohtsu)
    - #12913
* http:
  - parse errors are now reported when NODE_DEBUG=http (Sam Roberts)
    - #13206
  - Agent construction can now be envoked without `new` (cjihrig)
    - #12927
* zlib:
  - node will now throw an Error when zlib rejects the value of windowBits,
    instead of crashing (Alexey Orlenko)
    - #13098

PR-URL: #14356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

Assignees
No one assigned
Labels
https Issues or PRs related to the https subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @jasnell @MylesBorins @thefourtheye @lpinca @BridgeAR @nodejs-github-bot