Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,build: update configure help messages #12978

Closed
wants to merge 1 commit into from

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented May 11, 2017

  • The V8 inspector is no longer experimental.
  • Note that building without SSL disables other features.

Refs: #12768 (comment)

Checklist
Affected core subsystem(s)

doc, build

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label May 11, 2017
@gibfahn
Copy link
Member Author

gibfahn commented May 11, 2017

cc/ @refack @sam-github

@refack
Copy link
Contributor

refack commented May 11, 2017

I still want --without-ssl to scream, but this is definitely a good start 👍
Ohh, if you're there --without-intl also disables inspector

@refack refack added the tools Issues and PRs related to the tools directory. label May 11, 2017
configure Outdated
@@ -430,7 +430,7 @@ parser.add_option('--without-snapshot',
parser.add_option('--without-ssl',
action='store_true',
dest='without_ssl',
help='build without SSL')
help='build without SSL (disables crypto, https, inspector etc.)')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comma after inspector

- The V8 inspector is no longer experimental.
- Note that building without SSL disables other features.

PR-URL: nodejs#12978
Refs: nodejs#12768 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn
Copy link
Member Author

gibfahn commented May 22, 2017

refack pushed a commit to refack/node that referenced this pull request May 26, 2017
- The V8 inspector is no longer experimental.
- Note that building without SSL disables other features.

PR-URL: nodejs#12978
Refs: nodejs#12768 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@refack
Copy link
Contributor

refack commented May 26, 2017

Landed in e5e581c

@refack refack closed this May 26, 2017
@gibfahn gibfahn deleted the config-help branch May 26, 2017 18:30
jasnell pushed a commit that referenced this pull request May 28, 2017
- The V8 inspector is no longer experimental.
- Note that building without SSL disables other features.

PR-URL: #12978
Refs: #12768 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
- The V8 inspector is no longer experimental.
- Note that building without SSL disables other features.

PR-URL: #12978
Refs: #12768 (comment)
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants