deps/v8: add missing #include "unicode/normlzr.h" #13040

ArchangeGabriel · 2017-05-15T18:25:17Z

The following function from <unicode/normlzr.h> is used:
normalize()
Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU.

P.S.: This is my first PR in Node, and my first “real” PR in any project, so I don’t expect it to be alright from the start.

bnoordhuis

LGTM, thanks. CI: https://ci.nodejs.org/job/node-test-pull-request/8096/

MylesBorins · 2017-05-16T05:20:44Z

hey @ArchangeGabriel thanks for submitting this PR

This patch most likely needs to be sent upstream to V8 first. We could then backport the V8 patch to each appropriate release stream. /cc @fhinkel who might be able to help with this (a patch on V8 and then a backport to Node!!!)

As a heads up, v4.x is in maintenance mode, it would not likely land for a while due to not being critical bug fix as v4 ships with icu: '56.1'. You can find out more about the LTS process here

MylesBorins

-1 needs to be fixed in V8

edit:

this is not meaningful upstream to V8 so it makes sense to land it as a patch onto v6.x and backport to v4.x

bnoordhuis · 2017-05-16T07:25:04Z

@MylesBorins This patch is not relevant upstream, they are switching (or have switched) to ICU 59.

fhinkel · 2017-05-16T09:31:11Z

LGTM. Yes, upstream V8 wouldn't be right. Thanks @ArchangeGabriel !

MylesBorins · 2017-05-16T13:16:16Z

My apologies. I must have misunderstood something. Should this target master?

bnoordhuis · 2017-05-16T13:29:59Z

I don't think so, master bundles ICU 59. This is just for v4.x and v6.x since they bundle ICU 58.

ArchangeGabriel · 2017-05-16T13:51:19Z

master is not affected. This file is quite different in master, and already supports ICU 59. See #11753 for master and the v8 patches/links.

ArchangeGabriel · 2017-05-16T14:05:56Z

@MylesBorins To be more clear maybe: upstream v8 is not 4.x or 6.x v8, you only do cherry-pick.

Upstream v8 doesn’t need patching, because the current version supports ICU 59 (since patches/links from my previous comment).

Upstream v8 patches cannot be backported, because node 4.x and 6.x v8 doesn’t need the same fixes as upstream v8 for ICU 59, since the code is quite different.

MylesBorins · 2017-05-16T14:12:44Z

Ok excellent. I think it would make sense to Target v6.x and then we can backport to v4.x I can land this today and get it in the r.c. if we get sign off

…

On May 16, 2017 10:06 AM, "Bruno Pagani" ***@***.***> wrote: @MylesBorins <https://github.com/mylesborins> To be more clear maybe: upstream v8 is not 4.x or 6.x v8, you only do cherry-pick. Upstream v8 doesn’t need patching, because the current version supports ICU 59 (since patches/links from my previous comment). Upstream v8 patches cannot be backported, because node 4.x and 6.x v8 doesn’t need the same fixes as upstream v8 for ICU 59, since the code is quite different. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13040 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAecV4uXkZKEPe8f4xPVltkmM_NcW5E3ks5r6a1KgaJpZM4NbggI> .

ArchangeGabriel · 2017-05-16T14:22:49Z

OK, I’ve targeted v4.x first because it’s the one I have to use, but the fix is the same for v6.x.

I suppose you should also wait for ARM and ppc-linux CI to finish before merging?

MylesBorins · 2017-05-16T14:45:18Z

@ArchangeGabriel we generally waterfall from newer releases to older ones. Further v4.x is in maintenance, so a release won't be happening for quite a while for non critical bugs. If you are ok with it I'll update the issue to target v6.x and run CI again

I was wrong

MylesBorins · 2017-05-16T14:47:39Z

@nodejs/v8 how would we want to float a patch like this on V8 for v6.x? Should it bump patch number?

targos · 2017-05-16T14:59:04Z

Should it bump patch number?

Yes

ArchangeGabriel · 2017-05-16T15:00:48Z

@MylesBorins Yeah, sure. I fixed it on my side anyway, so this is mostly for other users/to be able to remove the patch from my build system. v6.x needs to be fixed too, I just didn’t open the v6.x PR in case this one would have required fixes.

MylesBorins · 2017-05-16T15:19:09Z

@ArchangeGabriel github was not able to smartly change target... I have a working branch (including V8 bump). Can you enable us to push to your branch so I can update?

MylesBorins · 2017-05-16T15:23:01Z

You can find the option on the right side of the screen at the bottom

Specifically this

ArchangeGabriel · 2017-05-16T15:24:40Z

This is already on.

MylesBorins · 2017-05-16T15:24:57Z

odd...

MylesBorins · 2017-05-16T15:27:09Z

Ahhh... I don't think we can force push.

here is the patch

MylesBorins@f00fe08

can you checkout v6.x-staging, cherry-pick, and force push over this branch. Sorry this is so convoluted

ArchangeGabriel · 2017-05-16T15:28:12Z

I can redo my branch to be only the patch on v6.x, and then you could add your bump and any other change, if that’s easier for you.

ArchangeGabriel · 2017-05-16T15:30:03Z

Our messages crossed. I’m doing that right now (but could take some time since I don’t think I can do that from GitHub web, so I’ll have to clone the repo locally first).

MylesBorins · 2017-05-16T15:30:19Z

@ArchangeGabriel whatever is easier for you. We only need to bump the patch number in deps/v8/include/v8-version.h. It should be part of the commit where the change is made

ArchangeGabriel · 2017-05-16T16:30:32Z

Done, sorry for the delay.

* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022

MylesBorins

LGTM

MylesBorins · 2017-05-18T01:23:17Z

@nodejs/lts anyone else want to review this?

gibfahn · 2017-05-18T08:56:30Z

Maybe cc/ @srl295 ?

ArchangeGabriel · 2017-05-26T19:23:19Z

Small ping. I’d like to get this fixed in Argon and Boron so that I could package them without an out-of-tree patch. :)

bnoordhuis · 2017-05-27T10:38:17Z

@ArchangeGabriel It has a couple of LGTMs, I expect it will land in the next v6.x patch release.

* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

MylesBorins · 2017-05-30T16:34:12Z

Landed in d3ae2f0

I'll backport to v4.x-staging but can make no guarantees when, if at all, we will land it

* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

ArchangeGabriel · 2017-05-30T19:19:26Z

Thanks! :) I’ll keep an eye on v4.x changes to see if that get merged, but I’ll just keep the patch in my tree else. ;)

* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: nodejs/node#13022 PR-URL: nodejs/node#13040 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: #13022 PR-URL: #13040 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Notable Changes: * **crypto**: - update root certificates (Ben Noordhuis) #13279 - update root certificates (Ben Noordhuis) #12402 * **deps**: - add support for more modern versions of INTL (Bruno Pagani) #13040 - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691 - upgrade openssl sources to 1.0.2l (Daniel Bevenius) #13233 PR-URL: #16500

ArchangeGabriel · 2017-11-14T16:55:17Z

@MylesBorins Thanks for having finally merged that patch in v4.x. :)

* The following function from <unicode/normlzr.h> is used: normalize() * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU. Refs: nodejs/node#13022 PR-URL: nodejs/node#13040 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

nodejs-github-bot added v4.x v8 engine Issues and PRs related to the V8 dependency. labels May 15, 2017

ArchangeGabriel mentioned this pull request May 15, 2017

Failling to build LTS versions with ICU 59 #13022

Closed

bnoordhuis approved these changes May 15, 2017

View reviewed changes

MylesBorins previously requested changes May 16, 2017

View reviewed changes

MylesBorins changed the base branch from v4.x-staging to v6.x-staging May 16, 2017 15:12

MylesBorins added v6.x and removed v4.x labels May 18, 2017

MylesBorins approved these changes May 18, 2017

View reviewed changes

MylesBorins force-pushed the v6.x-staging branch from 8347b9b to b09f738 Compare May 18, 2017 06:02

gibfahn approved these changes May 18, 2017

View reviewed changes

MylesBorins self-assigned this May 18, 2017

MylesBorins closed this May 30, 2017

MylesBorins mentioned this pull request Jun 6, 2017

v6.11.0 proposal #13059

Merged

ArchangeGabriel mentioned this pull request Jun 9, 2017

(v6.x backport) v8: fix build errors with g++ 7 #13574

Closed

4 tasks

MylesBorins mentioned this pull request Sep 20, 2017

v4.8.5 proposal #15507

Closed

MylesBorins mentioned this pull request Oct 25, 2017

v4.8.6 proposal #16500

Merged

abernix mentioned this pull request Nov 7, 2017

Release 1.5.4 meteor/meteor#9320

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps/v8: add missing #include "unicode/normlzr.h" #13040

deps/v8: add missing #include "unicode/normlzr.h" #13040

ArchangeGabriel commented May 15, 2017

bnoordhuis left a comment

MylesBorins commented May 16, 2017

MylesBorins left a comment •

edited

Loading

bnoordhuis commented May 16, 2017

fhinkel commented May 16, 2017

MylesBorins commented May 16, 2017

bnoordhuis commented May 16, 2017

ArchangeGabriel commented May 16, 2017

ArchangeGabriel commented May 16, 2017

MylesBorins commented May 16, 2017 via email

ArchangeGabriel commented May 16, 2017

MylesBorins commented May 16, 2017

MylesBorins commented May 16, 2017

targos commented May 16, 2017

ArchangeGabriel commented May 16, 2017

MylesBorins commented May 16, 2017 •

edited

Loading

MylesBorins commented May 16, 2017 •

edited

Loading

ArchangeGabriel commented May 16, 2017

MylesBorins commented May 16, 2017

MylesBorins commented May 16, 2017

ArchangeGabriel commented May 16, 2017

ArchangeGabriel commented May 16, 2017 •

edited

Loading

MylesBorins commented May 16, 2017

ArchangeGabriel commented May 16, 2017

MylesBorins left a comment

MylesBorins commented May 18, 2017

gibfahn commented May 18, 2017

ArchangeGabriel commented May 26, 2017

bnoordhuis commented May 27, 2017

MylesBorins commented May 30, 2017

ArchangeGabriel commented May 30, 2017

ArchangeGabriel commented Nov 14, 2017

deps/v8: add missing #include "unicode/normlzr.h" #13040

deps/v8: add missing #include "unicode/normlzr.h" #13040

Conversation

ArchangeGabriel commented May 15, 2017

bnoordhuis left a comment

Choose a reason for hiding this comment

MylesBorins commented May 16, 2017

MylesBorins left a comment • edited Loading

Choose a reason for hiding this comment

bnoordhuis commented May 16, 2017

fhinkel commented May 16, 2017

MylesBorins commented May 16, 2017

bnoordhuis commented May 16, 2017

ArchangeGabriel commented May 16, 2017

ArchangeGabriel commented May 16, 2017

MylesBorins commented May 16, 2017 via email

ArchangeGabriel commented May 16, 2017

MylesBorins commented May 16, 2017

MylesBorins commented May 16, 2017

targos commented May 16, 2017

ArchangeGabriel commented May 16, 2017

MylesBorins commented May 16, 2017 • edited Loading

MylesBorins commented May 16, 2017 • edited Loading

ArchangeGabriel commented May 16, 2017

MylesBorins commented May 16, 2017

MylesBorins commented May 16, 2017

ArchangeGabriel commented May 16, 2017

ArchangeGabriel commented May 16, 2017 • edited Loading

MylesBorins commented May 16, 2017

ArchangeGabriel commented May 16, 2017

MylesBorins left a comment

Choose a reason for hiding this comment

MylesBorins commented May 18, 2017

gibfahn commented May 18, 2017

ArchangeGabriel commented May 26, 2017

bnoordhuis commented May 27, 2017

MylesBorins commented May 30, 2017

ArchangeGabriel commented May 30, 2017

ArchangeGabriel commented Nov 14, 2017

MylesBorins left a comment •

edited

Loading

MylesBorins commented May 16, 2017 •

edited

Loading

MylesBorins commented May 16, 2017 •

edited

Loading

ArchangeGabriel commented May 16, 2017 •

edited

Loading