-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor test-dns-regress-6244.js #13058
Conversation
* Move from parallel to internet because it performs a DNS query * Provide link to relevant issue in comments * Remove unnecessary explicit no-op function
@nodejs/testing |
My only issue with this would be that the internet tests don't get run very much, so moving to internet basically means ignoring. Of course if there's no feasible way to do this offline then we have no choice. |
Landed in 47e3d00 |
* Move from parallel to internet because it performs a DNS query * Provide link to relevant issue in comments * Remove unnecessary explicit no-op function PR-URL: nodejs#13058 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
* Move from parallel to internet because it performs a DNS query * Provide link to relevant issue in comments * Remove unnecessary explicit no-op function PR-URL: nodejs#13058 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This test does not pass on v6.x Please feel free to backport |
@MylesBorins Are you sure? That's strange because this moves the test from parallel to internet which means |
@Trott when backporting we normally run any tests that were changed, not just the ones that This fails as follows: ➜ node git:(v6.x-staging) ✗ ❯ tools/test.py test/internet/test-dns-regress-6244.js ~/wrk/com/DANGER/node
=== release test-dns-regress-6244 ===
Path: internet/test-dns-regress-6244
/Users/gib/wrk/com/DANGER/node/test/common/index.js:431
name: fn.name || '<anonymous>'
^
TypeError: Cannot read property 'name' of undefined
at Object.exports.mustCall (/Users/gib/wrk/com/DANGER/node/test/common/index.js:431:13)
at Object.<anonymous> (/Users/gib/wrk/com/DANGER/node/test/internet/test-dns-regress-6244.js:6:34)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
at run (bootstrap_node.js:389:7)
at startup (bootstrap_node.js:149:9)
Command: out/Release/node /Users/gib/wrk/com/DANGER/node/test/internet/test-dns-regress-6244.js
[00:00|% 100|+ 0|- 1]: Done Given that the only code change in the pr is |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test dns