Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.x backport for common.crashOnUnhandledRejection #13103

Closed
wants to merge 2 commits into from
Closed

v6.x backport for common.crashOnUnhandledRejection #13103

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

No description provided.

@addaleax
test: introduce common.crashOnUnhandledRejection
cb5c93a 
Ref: nodejs#12442
PR-URL: nodejs#12489
Reviewed-By: Matthew Loring <mattloring@google.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
test,doc: document crashOnUnhandledRejection()
46d6281 
Add documentation for `common.crashOnUnhandledRejection()`.

Ref: https://github.com/nodejs/node/pull/12489/files/a9c2078a60bc3012dc6156df19772697a56a2517#r113737423
PR-URL: nodejs#12699
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels May 18, 2017
@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

CI: https://ci.nodejs.org/job/node-test-commit/10629/

gibfahn pushed a commit to gibfahn/node that referenced this pull request Jun 17, 2017
@addaleax @gibfahn
test: introduce common.crashOnUnhandledRejection
4848862 
Ref: nodejs#12442
PR-URL: nodejs#12489
Backport-PR-URL: nodejs#13103
Reviewed-By: Matthew Loring <mattloring@google.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit to gibfahn/node that referenced this pull request Jun 17, 2017
@addaleax @gibfahn
test,doc: document crashOnUnhandledRejection()
dfcefd6 
Add documentation for `common.crashOnUnhandledRejection()`.

Ref: https://github.com/nodejs/node/pull/12489/files/a9c2078a60bc3012dc6156df19772697a56a2517#r113737423
PR-URL: nodejs#12699
Backport-PR-URL: nodejs#13103
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Jun 17, 2017

Landed in dfcefd6 and 4848862

@gibfahn gibfahn closed this Jun 17, 2017
@gibfahn gibfahn added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 20, 2017
@gibfahn
Copy link
Member

gibfahn commented Jun 20, 2017 •
edited
Loading

$expletive! I didn't notice the original PR was a semver-minor. Reopened and removed.

Thanks to @MylesBorins for catching this.

@gibfahn gibfahn reopened this Jun 20, 2017
@addaleax addaleax removed the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 20, 2017
@addaleax
Copy link
Member Author

@gibfahn Neither commit here is semver-minor, or touches Node’s API in any way.

gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@addaleax @gibfahn
test: introduce common.crashOnUnhandledRejection
0a3b59b 
Ref: #12442
PR-URL: #12489
Backport-PR-URL: #13103
Reviewed-By: Matthew Loring <mattloring@google.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@addaleax @gibfahn
test,doc: document crashOnUnhandledRejection()
b483675 
Add documentation for `common.crashOnUnhandledRejection()`.

Ref: https://github.com/nodejs/node/pull/12489/files/a9c2078a60bc3012dc6156df19772697a56a2517#r113737423
PR-URL: #12699
Backport-PR-URL: #13103
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Jun 20, 2017 •
edited
Loading

🤦‍♂️ You're right, don't know how I missed the file names.

Landed again in 0a3b59b b483675

@gibfahn gibfahn closed this Jun 20, 2017
@addaleax addaleax deleted the backport-cour-v6.x branch June 20, 2017 19:16
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@addaleax @MylesBorins
test: introduce common.crashOnUnhandledRejection
4eb28c8 
Ref: #12442
PR-URL: #12489
Backport-PR-URL: #13103
Reviewed-By: Matthew Loring <mattloring@google.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@addaleax @MylesBorins
test,doc: document crashOnUnhandledRejection()
4dff128 
Add documentation for `common.crashOnUnhandledRejection()`.

Ref: https://github.com/nodejs/node/pull/12489/files/a9c2078a60bc3012dc6156df19772697a56a2517#r113737423
PR-URL: #12699
Backport-PR-URL: #13103
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@leonardoadame leonardoadame mentioned this pull request Nov 30, 2023
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
Open
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
This was referenced May 14, 2024
Open
Open
@aliscco aliscco mentioned this pull request May 15, 2024
Open
This was referenced May 16, 2024
Open
Open
@aliscco aliscco mentioned this pull request May 17, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @gibfahn @evanlucas @thefourtheye @nodejs-github-bot