Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: setup cluster workers before preloading #1314

Closed
wants to merge 1 commit into from

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Apr 1, 2015

We need to process cluster workers before any preload modules is
executed. Otherwise, the child processes are not correctly disovered
as clustered workers inside the preloaded modules.

Fixes: #1269

We need to process cluster workers before any preload modules is
executed. Otherwise, the child processes are not correctly disovered
as clustered workers inside the preloaded modules.

Fixes: nodejs#1269
@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Apr 1, 2015
@bnoordhuis
Copy link
Member

LGTM. Can someone from @iojs/collaborators who was involved in the original PR (#881) sign off on this as well (and land it)?

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/428/

@indutny
Copy link
Member

indutny commented Apr 1, 2015

LGTM

bnoordhuis pushed a commit that referenced this pull request Apr 3, 2015
We need to process cluster workers before any preload modules is
executed. Otherwise, the child processes are not correctly disovered
as clustered workers inside the preloaded modules.

Fixes: #1269
PR-URL: #1314
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@bnoordhuis
Copy link
Member

I guess the finer nuances of "and land it" didn't get across but no worries, landed in b6e22c4, thanks. :-)

@bnoordhuis bnoordhuis closed this Apr 3, 2015
@ofrobots ofrobots deleted the fix-1269 branch August 24, 2015 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants