test: fix disabled test-fs-largefile #13147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `common.refreshTmpDir()` before using the tmp directory. fs.writeSync no longer requires an integer for the position argument, so change test from `assert.throws()` to `assert.doesNotThrow()`. The test now passes. Because it involves a 5 GB file, we're not going to activate the test, although that is possible if we add checking for appropriate available resources (definitely disk space, likely memory, maybe check that it's a 64-bit OS).
Trott
added
fs
|
Also, consider file system restrictions (FAT32 cannot have a 5 GB file etc). |
jasnell
approved these changes
May 22, 2017
|
Sole CI failure is an unrelated build issue. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 24, 2017
Add `common.refreshTmpDir()` before using the tmp directory. fs.writeSync no longer requires an integer for the position argument, so change test from `assert.throws()` to `assert.doesNotThrow()`. The test now passes. Because it involves a 5 GB file, we're not going to activate the test, although that is possible if we add checking for appropriate available resources (definitely disk space, likely memory, maybe check that it's a 64-bit OS). PR-URL: nodejs#13147 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in bbf74fb |
jasnell
pushed a commit
that referenced
this pull request
May 25, 2017
Add `common.refreshTmpDir()` before using the tmp directory. fs.writeSync no longer requires an integer for the position argument, so change test from `assert.throws()` to `assert.doesNotThrow()`. The test now passes. Because it involves a 5 GB file, we're not going to activate the test, although that is possible if we add checking for appropriate available resources (definitely disk space, likely memory, maybe check that it's a 64-bit OS). PR-URL: #13147 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
Add `common.refreshTmpDir()` before using the tmp directory. fs.writeSync no longer requires an integer for the position argument, so change test from `assert.throws()` to `assert.doesNotThrow()`. The test now passes. Because it involves a 5 GB file, we're not going to activate the test, although that is possible if we add checking for appropriate available resources (definitely disk space, likely memory, maybe check that it's a 64-bit OS). PR-URL: #13147 Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
|
should this land on v6.x? |
@MylesBorins I would say "no" and have added dont-land labels for 6.x and 4.x. |
|
@Trott maybe we could add this test to pummel? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
common.refreshTmpDir()before using the tmp directory.fs.writeSync no longer requires an integer for the position argument, so
change test from
assert.throws()toassert.doesNotThrow(). The testnow passes.
Because it involves a 5 GB file, we're not going to activate the test,
although that is possible if we add checking for appropriate available
resources (definitely disk space, likely memory, maybe check that it's a
64-bit OS).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test fs