Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cover util.format() format placeholders #13159

Closed
wants to merge 1 commit into from
Closed

test: cover util.format() format placeholders #13159

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 22, 2017

This commit adds coverage for several edge cases related to util.format() format string placeholders.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@cjihrig
test: cover util.format() format placeholders
bac307b 
This commit adds coverage for several edge cases related to
util.format() format string placeholders.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 22, 2017
@mscdex mscdex added the util Issues and PRs related to the built-in util module. label May 22, 2017
@addaleax
Copy link
Member

Landed in 0903dcf

@addaleax addaleax closed this May 25, 2017
@cjihrig cjihrig deleted the util branch May 25, 2017 15:59
addaleax pushed a commit that referenced this pull request May 25, 2017
@cjihrig @addaleax
test: cover util.format() format placeholders
0903dcf 
This commit adds coverage for several edge cases related to
util.format() format string placeholders.

PR-URL: #13159
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell pushed a commit that referenced this pull request May 25, 2017
@cjihrig @jasnell
test: cover util.format() format placeholders
4ce027c 
This commit adds coverage for several edge cases related to
util.format() format string placeholders.

PR-URL: #13159
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell pushed a commit that referenced this pull request May 28, 2017
@cjihrig @jasnell
test: cover util.format() format placeholders
5ad4170 
This commit adds coverage for several edge cases related to
util.format() format string placeholders.

PR-URL: #13159
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @addaleax @MylesBorins @refack @jasnell @evanlucas @lpinca @watilde @mscdex @nodejs-github-bot