Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make StreamBase::GetAsyncWrap pure virtual #13174

Closed
wants to merge 1 commit into from
Closed

src: make StreamBase::GetAsyncWrap pure virtual #13174

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented May 23, 2017 •
edited
Loading

Splitting out from #13142, this is a bit that should be easy to review. (All remaining GetAsyncWrap methods never return nullptr.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 23, 2017
@addaleax addaleax added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 23, 2017
AndreasMadsen
AndreasMadsen approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@AndreasMadsen AndreasMadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax addaleax mentioned this pull request May 24, 2017
Merged
2 tasks
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/10151/

@addaleax
Copy link
Member Author

Landed in 169c07d

@addaleax addaleax closed this May 25, 2017
@addaleax addaleax deleted the stream-wrap-virtual-gaw branch May 25, 2017 18:02
addaleax added a commit that referenced this pull request May 25, 2017
@addaleax
src: make StreamBase::GetAsyncWrap pure virtual
169c07d 
PR-URL: #13174
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell pushed a commit that referenced this pull request May 25, 2017
@addaleax @jasnell
src: make StreamBase::GetAsyncWrap pure virtual
b409919 
PR-URL: #13174
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
@addaleax @jasnell
src: make StreamBase::GetAsyncWrap pure virtual
b4f6ea0 
PR-URL: #13174
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 14, 2017
@MylesBorins
Copy link
Contributor

@addaleax should we land this now or wait for a larger async_hooks update?

@addaleax addaleax removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 14, 2017
@addaleax
Copy link
Member Author

@MylesBorins This is not the kind of change that would be harmful to include, or that would need to bake for any significant time. If it compiles, include it. :)

@MylesBorins
Copy link
Contributor

@addaleax it does not land cleanly, I don't think the async_wrap stuff has been backported

@MylesBorins
Copy link
Contributor

ping re: backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@AndreasMadsen AndreasMadsen AndreasMadsen approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @MylesBorins @danbev @jasnell @AndreasMadsen @cjihrig @mscdex @nodejs-github-bot