Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix code example in inspector.md #13182

Closed
wants to merge 1 commit into from
Closed

doc: fix code example in inspector.md #13182

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
Affected core subsystem(s)

doc, inspector

console.log(result.value) outputs just 4.

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels May 24, 2017
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels May 24, 2017
@vsemozhetbyt
Copy link
Contributor Author

Linter CI: https://ci.nodejs.org/job/node-test-linter/9305/

refack
refack approved these changes May 24, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we lint for space inside object literals? { a }

@vsemozhetbyt
Copy link
Contributor Author

@refack No, but this is rather common in the docs.

@refack
Copy link
Contributor

refack commented May 24, 2017

@refack No, but this is rather common in the docs.

I personally like it. If it's common we should lint for it.

@vsemozhetbyt
Copy link
Contributor Author

Well, if there is some unanimity for this, I could address this. But I would not bother everybody with this PR for spaces only, I've just fixed the result.value issue and other nits besides.

@vsemozhetbyt
Copy link
Contributor Author

Landed in 329b6e9

@vsemozhetbyt vsemozhetbyt deleted the inspector.md branch May 26, 2017 08:54
vsemozhetbyt added a commit that referenced this pull request May 26, 2017
@vsemozhetbyt
doc: fix code example in inspector.md
329b6e9 
PR-URL: #13182
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
@vsemozhetbyt @jasnell
doc: fix code example in inspector.md
c0a7c8e 
PR-URL: #13182
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vsemozhetbyt @refack @jasnell @cjihrig @MylesBorins @nodejs-github-bot