test: use common.mustNotCall in test-crypto-random #13183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `common.mustNotCall()` to confirm that noop callbacks are not run when functions throw errors.
Trott
added
crypto
lpinca
approved these changes
May 24, 2017
danbev
approved these changes
May 24, 2017
benjamingr
approved these changes
May 24, 2017
jasnell
approved these changes
May 24, 2017
cjihrig
approved these changes
May 24, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 26, 2017
Use `common.mustNotCall()` to confirm that noop callbacks are not run when functions throw errors. PR-URL: nodejs#13183 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 112ef23 |
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
Use `common.mustNotCall()` to confirm that noop callbacks are not run when functions throw errors. PR-URL: #13183 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
common.mustNotCall()to confirm that noop callbacks are not runwhen functions throw errors.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test crypto