test: improve n-api coverage for typed arrays #13244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add testing for all types of typed arrays. Add testing for napi_is_arraybuffer.
nodejs-github-bot
added
node-api
cjihrig
approved these changes
May 26, 2017
|
|
||
| assert.ok(theArray instanceof currentType, | ||
| 'Type of new array should match that of the template'); | ||
| assert.ok(theArray !== template); |
jasongin
approved these changes
May 26, 2017
| NAPI_ASSERT(env, valuetype0 == napi_object, | ||
| "Wrong type of argments. Expects a typed array as first argument."); | ||
|
|
||
| napi_value input_array = args[0]; |
There was a problem hiding this comment.
nit: Can you declare napi_value input_array = args[0]; and napi_value input_buffer = args[1]; around line 104 for better readability and reuse it on line 106 and 119 respectively?
|
Pushed commit to address comments |
jasnell
approved these changes
May 30, 2017
kunalspathak
approved these changes
May 30, 2017
digitalinfinity
approved these changes
May 30, 2017
|
CI run good, landing. |
|
landed as effeff1 |
mhdawson
added a commit
that referenced
this pull request
May 30, 2017
Add testing for all types of typed arrays. Add testing for napi_is_arraybuffer. PR-URL: #13244 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
Add testing for all types of typed arrays. Add testing for napi_is_arraybuffer. PR-URL: #13244 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Closed
3 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Add testing for all types of typed arrays. Add testing for napi_is_arraybuffer. PR-URL: nodejs#13244 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Add testing for all types of typed arrays. Add testing for napi_is_arraybuffer. Backport-PR-URL: #19447 PR-URL: #13244 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testing for all types of typed arrays.
Add testing for napi_is_arraybuffer.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, n-api