Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: improve performance #13261

Merged
merged 3 commits into from
Jun 2, 2017
Merged

dns: improve performance #13261

merged 3 commits into from
Jun 2, 2017

Commits on Jun 2, 2017

  1. test: improve dns internet test case 

    0.0.0.0 is more common than other special ipv4 addresses, so
it is possible that we may not get ENOTFOUND for such addresses.
Instead, this commit uses a less common address that is reserved
for documentation (RFC) use only.

PR-URL: nodejs#13261
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @mscdex
    mscdex committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    8d7ff6d View commit details
    Browse the repository at this point in the history

  2. dns: improve callback performance 

    It appears that either c-ares no longer calls callbacks synchronously
or we have since explicitly taken care of the scenarios in which
c-ares would call callbacks synchronously (e.g. resolving an IP
address or an empty hostname). Therefore we no longer need to have
machinery in place to handle possible synchronous callback invocation.
This improves performance significantly.

PR-URL: nodejs#13261
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @mscdex
    mscdex committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    656bb71 View commit details
    Browse the repository at this point in the history

  3. dns: use faster IP address type check on results 

    PR-URL: nodejs#13261
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @mscdex
    mscdex committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    3c989de View commit details
    Browse the repository at this point in the history