Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: remove CopyProperties()- code review #13265

Closed
wants to merge 1 commit into from

Commits on Oct 15, 2017

  1. vm: remove CopyProperties() for named properties

    Extend NamedPropertyHandlerConfiguration
    with PropertyDescriptorCallback and
    PropertyDefinerCallback, which query
    ES6 property descriptors and use
    DefineProperty() API.
    
    CopyProperties() is removed.
    A number of tests can be moved from
    /known_issues to /parallel.
    
    This is a code review PR:
    - it uses V8 API changes, which are yet
    to land,
    - it temporarily breaks property defining
    for indexed properties.
    AnnaMag committed Oct 15, 2017
    Configuration menu
    Copy the full SHA
    2b7fe69 View commit details
    Browse the repository at this point in the history