Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-https-server-keep-alive-timeout #13312

Closed
wants to merge 3 commits into from
Closed

test: improve test-https-server-keep-alive-timeout #13312

wants to merge 3 commits into from

Commits on Jun 1, 2017

  1. test: improve test-https-server-keep-alive-timeout 

    The test is flaky under load. These changes greatly improve reliability.

* Use a recurring interval to determine when the test should end rather
  than a timer.
* Increase server timeout to 500ms to allow for events being delayed by
  system load

Changing to an interval has the added benefit of reducing the test run
time from over 2 seconds to under 1 second.

Fixes: nodejs#13307
    @Trott
    Trott committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    eedefc7 View commit details
    Browse the repository at this point in the history

  2. squash: additional refactor per lpinca

    @Trott
    Trott committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    80c1f44 View commit details
    Browse the repository at this point in the history

  3. squash: nits from refack

    @Trott
    Trott committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    e89d8ca View commit details
    Browse the repository at this point in the history