Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in CHANGELOG #13313

Closed
wants to merge 1 commit into from
Closed

Fix link in CHANGELOG #13313

wants to merge 1 commit into from

Conversation

jamesplease
Copy link
Contributor

@jamesplease jamesplease commented May 30, 2017 •
edited
Loading

📝

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 30, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request May 30, 2017
Closed
jasnell pushed a commit that referenced this pull request Jun 1, 2017
@jamesplease @jasnell
doc: fix link in CHANGELOG_V8
17e10b3 
PR-URL: #13313
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 1, 2017

Landed in 17e10b3

@jasnell jasnell closed this Jun 1, 2017
@jamesplease jamesplease deleted the patch-1 branch June 1, 2017 23:21
@jamesplease
Copy link
Contributor Author

oh cool, I can update my Twitter profile:

NodeJS Core Contributor

👌

@refack
Copy link
Contributor

refack commented Jun 2, 2017

oh cool, I can update my Twitter profile:

NodeJS Core Contributor
👌

Every bit help!
Thanks for the contrib 🥇

jasnell pushed a commit that referenced this pull request Jun 5, 2017
@jamesplease @jasnell
doc: fix link in CHANGELOG_V8
1729574 
PR-URL: #13313
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell mentioned this pull request Jun 5, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jamesplease @jasnell @refack @lpinca @cjihrig @vsemozhetbyt @MylesBorins @nodejs-github-bot