test: test async-hook triggerId invariant #13328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
async_hooks
jasnell
reviewed
May 31, 2017
| process.nextTick(() => { | ||
| process.nextTick(() => { | ||
| triggerId1 = triggerId(); | ||
| assert.notEqual(triggerId0, triggerId1, "Async resources having different causal ancestry should have different triggerIds") |
There was a problem hiding this comment.
long line here. please line break at <= 80 chars and run make lint :-)
There was a problem hiding this comment.
Also, this should likely use assert.notStrictEqual()
jasnell
reviewed
May 31, 2017
| }) | ||
| process.nextTick(() => { | ||
| const triggerId2 = triggerId(); | ||
| assert.equal(triggerId1, triggerId2, |
|
Mind adding a comment in the commit message body about what important scenario/etc. this is testing for? |
Add tests for checking the behavior of async_hooks.triggerId. It should return different ids when called in callbacks having different ancestry paths. It should return the same id when called in callbacks having the same ancestry path.
dszakallas
force-pushed
the
test-async-hook-triggerid
branch
from
01679cc
to
3a5826c
Compare
|
updated! |
trevnorris
approved these changes
Jun 2, 2017
addaleax
approved these changes
Jun 3, 2017
|
Landed in fcab69c, thank you for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Jun 3, 2017
Add tests for checking the behavior of async_hooks.triggerId. It should return different ids when called in callbacks having different ancestry paths. It should return the same id when called in callbacks having the same ancestry path. PR-URL: #13328 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 3, 2017
Add tests for checking the behavior of async_hooks.triggerId. It should return different ids when called in callbacks having different ancestry paths. It should return the same id when called in callbacks having the same ancestry path. PR-URL: #13328 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
Add tests for checking the behavior of async_hooks.triggerId. It should return different ids when called in callbacks having different ancestry paths. It should return the same id when called in callbacks having the same ancestry path. PR-URL: #13328 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
Adds two tests to check that the
triggerIdinvariant is satisfied, that is async resources with the same cause have the sametriggerId, while those with different cause have differenttriggerIds.