Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: use parent promise as triggerId in init hook #13367

Closed
wants to merge 3 commits into from
Closed

async_hooks: use parent promise as triggerId in init hook #13367

wants to merge 3 commits into from

Commits on Jun 2, 2017

  1. async_hooks: use parent promise as triggerId in init hook 

    async_hooks init callback will be triggered when promise newly created,
in previous version, the parent promise which pass from chrome V8 PromiseHook
is ignored, so we can't tell the promise is a pure new promise or a
chained promise.

In this commit, we use the parent promise's id as triggerId to
trigger the init callback.

Fixes: nodejs#13302
    @JiaLiPassion
    JiaLiPassion committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    979894c View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2017

  1. async_hooks: add test cases for triggerId of promise init hook

    @JiaLiPassion
    JiaLiPassion committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    c0e5464 View commit details
    Browse the repository at this point in the history

  2. [squash] cleanup tests

    @AndreasMadsen
    AndreasMadsen committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    b8f8f4b View commit details
    Browse the repository at this point in the history