test,module: make message check MUI dependent

[refack]

Fixes: #13376

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added - comments
• commit message follows commit guidelines

Affected core subsystem(s)

test,module

[refack]

Dry-run CI: https://ci.nodejs.org/job/node-test-commit/10308/

[refack]

Explaining + nits

[refack]

/s/message/messages

[refack]

and a comma after Windows

[refack]

addressed

[refack]

putting it in a separate line makes for easy breakpoint setting.

[gibfahn]

This seems like an unnecessary change. Not sure about other debuggers, but chrome://inspect allows you to set breakpoints on statements within a line:

[refack]

replace dlerror_msg truthy check for a trivial fallback (Line 34) mostly for keeping line short.

[refack]

simplify

[tniessen]

I fear this might actually be 'en\r\n'. Maybe .startsWith('en'), or even .includes('en'), or trim the output?

[refack]

Ack.

[refack]

New CI: https://ci.nodejs.org/job/node-test-commit/10310/

[tniessen]

Just discovered that this method is not 100% accurate (I changed the locale, logged off and back in without rebooting), but I think it is close enough.

> require('./test/fixtures/module-loading-error.node')
Error: %1 is not a valid Win32 application.
\\?\E:\node\test\fixtures\module-loading-error.node
    at Error (native)
    at Object.Module._extensions..node (module.js:597:18)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at repl:1:1
    at sigintHandlersWrap (vm.js:22:35)
    at sigintHandlersWrap (vm.js:96:12)
>
(To exit, press ^C again or type .exit)
>

E:\node>powershell -NoProfile -ExecutionPolicy Unrestricted -c "(Get-UICulture).TwoLetterISOLanguageName"
de

Will approve if CI passes.

[tniessen]

Maybe use camelCase (dlErrorMsg) for consistency while you are at it?

[jasnell]

s/if/If and add a period at the end

[refack]

Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/9534/

[refack]

Full CI: https://ci.nodejs.org/job/node-test-commit/10325/

[tniessen]

Thank you for implementing this!

[gibfahn]

errorMsgsByPlafrom -> errorMsgsByPlatform (and below)

[refack]

in for penny in for a pound: errorMessagesByPlatform

[gibfahn]

This seems like an unnecessary change. Not sure about other debuggers, but chrome://inspect allows you to set breakpoints on statements within a line:

[gibfahn]

If this line fails and we hit the catch, won't localeOk still be true rather than false?

i.e. should you do this?

if (common.isWindows) {
+  localeOk = false;
  const powerShellFindMUI =

[refack]

Intentionally I chose to be strict. the less use of the "escape hatch" the better the coverage 🤔

[gibfahn]

If the powershell script fails will it log an error to the console? If so then I guess that's fine.

[refack]

Yea because execSync pipes stderr from the child we get the error (this one is a synthetic syntax error):

C:\bin\dev\node\node.exe D:\code\node\test\parallel\test-module-loading-error.js
Get-UICulture2 : The term 'Get-UICulture2' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:2
+ (Get-UICulture2).TwoLetterISOLanguageName
+  ~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Get-UICulture2:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
 

Process finished with exit code 0

Notice that the exit code is 0

[refack]

Landed in 30a20bd

[MylesBorins]

Should this be backported to v6.x?

[refack]

Yes. Does not land cleanly, I will backport.