Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rearrange inspector headers into convention #13428

Merged
merged 1 commit into from
Jun 5, 2017
Merged

test: rearrange inspector headers into convention #13428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/inspector/test-inspector-debug-brk.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
'use strict';
const common = require('../common');

common.skipIfInspectorDisabled();

const assert = require('assert');
const helper = require('./inspector-helper.js');

Expand Down
1 change: 1 addition & 0 deletions test/inspector/test-inspector-ip-detection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');

common.skipIfInspectorDisabled();

const assert = require('assert');
Expand Down
3 changes: 2 additions & 1 deletion test/inspector/test-inspector-port-zero-cluster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
// Flags: --inspect=0
'use strict';

const common = require('../common');

common.skipIfInspectorDisabled();

const assert = require('assert');
const cluster = require('cluster');

Expand Down
3 changes: 2 additions & 1 deletion test/inspector/test-inspector-port-zero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
'use strict';

const { mustCall, skipIfInspectorDisabled } = require('../common');

skipIfInspectorDisabled();

const assert = require('assert');
const { URL } = require('url');
const { spawn } = require('child_process');
Expand Down
1 change: 1 addition & 0 deletions test/inspector/test-inspector-stops-no-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
require('../common');

const spawn = require('child_process').spawn;

const child = spawn(process.execPath,
Expand Down
2 changes: 2 additions & 0 deletions test/inspector/test-inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
'use strict';
const common = require('../common');

common.skipIfInspectorDisabled();

const assert = require('assert');
const helper = require('./inspector-helper.js');

Expand Down
2 changes: 2 additions & 0 deletions test/parallel/test-cluster-inspector-debug-port.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
'use strict';
// Flags: --inspect={PORT}
const common = require('../common');

common.skipIfInspectorDisabled();

const assert = require('assert');
const cluster = require('cluster');
const debuggerPort = common.PORT;
Expand Down
7 changes: 4 additions & 3 deletions test/parallel/test-inspector-invalid-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
'use strict';
const common = require('../common');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott this is not whitespace only. I can remove all the other whitespace only changes if you'd like, I think they are more readable, and I think they are implied by the test guide, but this change, specifically, brings this test into conformance with the guide.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes, missed that one, sorry. Anyway, yeah, it's all fine. No objections.


common.skipIfInspectorDisabled();

const assert = require('assert');
const execFile = require('child_process').execFile;
const path = require('path');

const common = require('../common');
common.skipIfInspectorDisabled();

const mainScript = path.join(common.fixturesDir, 'loop.js');
const expected =
'`node --debug` and `node --debug-brk` are invalid. ' +
Expand Down