-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: rename process._inspectorEnbale #13460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ at least it so new nobody's used it yet
Any reason not to fast track this? |
@cjihrig Thanks for finding this 🎁 |
Heh, I didn't exactly find it. #9659 (comment) |
src/node.cc
Outdated
@@ -3404,7 +3404,7 @@ void SetupProcessObject(Environment* env, | |||
// --inspect | |||
if (debug_options.inspector_enabled()) { | |||
READONLY_DONT_ENUM_PROPERTY(process, | |||
"_inspectorEnbale", True(env->isolate())); | |||
"_inspectorEnable", True(env->isolate())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe _inspectorEnabled
is better?
So @mutantcornholio the 🏆 goes to you. |
Can we add a test for this? |
I'll do a new PR first thing tomorrow. But IMHO lack of testing should not block this. |
@cjihrig there is a typo on the commit message and the title of the PR. |
@mcollina I think that was the fix of this PR ;-) |
oooh, that was not clear. |
Updated to |
I say land after 24 hours (in 10 hours 02:00 UTC) unless anyone objects |
I thought it might be just for our internal use, to communicate from C++ init to later js, but we have no references to this property anywhere other than its definition. So, must be for external users? If so, isn't this |
Well, first internal use will be here (after this PR gets merged): #9659 (comment) |
It's brand new (16689e3), and AFAIK never used. Was a bit of future proofing. |
Alternatively, if the property is unused, maybe it should be deleted, see #13228 (comment) and conversation after. |
Note that #13228 allows checking whether the inspector port is open or not with a documented API (instead of an _ prefixed and undocumented property on process), and is accurate whether the port was opened using |
|
I'm fine with removing it here. That still leaves the semver question though. |
It's an |
I think the policy would be to deprecate |
AIUI the formal policy is that underscore properties are not subject to semver (although the CTC makes exceptions for things that people use). |
Given that this is (a) new and (b) and obvious mistake, it's worth fixing as a semver-patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not need to wait the 48 hours to land
Adding my voice to "If this requires CTC-approval to be treated as |
Just to clarify, are we talking about landing this as is, or removing the property? |
@cjihrig I meant either renaming or removing. I'm fine with treating either as |
CI to remove the property: https://ci.nodejs.org/job/node-test-pull-request/8497/ |
This commit removes process._inspectorEnbale which was spelled incorrectly, and is being properly implemented in a separate PR. Refs: nodejs#12949 PR-URL: nodejs#13460 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luca Maraschi <luca.maraschi@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
🎉 |
This commit removes process._inspectorEnbale which was spelled incorrectly, and is being properly implemented in a separate PR. Refs: #12949 PR-URL: #13460 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luca Maraschi <luca.maraschi@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This seems like a typo. This commit changes the property to
process._inspectorEnable
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
src