Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make IsConstructCall checks consistent #13473

Closed
wants to merge 1 commit into from
Closed

src: make IsConstructCall checks consistent #13473

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Jun 5, 2017 •
edited
Loading

The most common way to perfom this check is by using the simple CHECK
macro. This commit suggest making this consistent in favour of the most
commonly used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jun 5, 2017
@danbev
Copy link
Contributor Author

danbev commented Jun 5, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8479/

bnoordhuis
bnoordhuis approved these changes Jun 5, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Typo in commit log: s/constent/consistent/

EDIT: "suggest to making this constent" has more grammar issues.

mhdawson
mhdawson approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danbev
src: make IsConstructCall checks consistent
79ccc6d 
The most common way to perfom this check is by using the simple CHECK
macro. This commit suggest making this consistent in favour of the most
commonly used.
@danbev danbev force-pushed the make-IsConstructCall-constent branch from 5ebf505 to 79ccc6d Compare June 8, 2017 08:25
@danbev
Copy link
Contributor Author

danbev commented Jun 8, 2017

LGTM. Typo in commit log: s/constent/consistent/

EDIT: "suggest to making this constent" has more grammar issues.

Thanks, I've corrected these issues now.

danbev added a commit to danbev/node that referenced this pull request Jun 8, 2017
@danbev
src: make IsConstructCall checks consistent
f38302d 
The most common way to perfom this check is by using the simple CHECK
macro. This commit suggest making this consistent in favour of the most
commonly used.

PR-URL: nodejs#13473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danbev
Copy link
Contributor Author

danbev commented Jun 8, 2017

Landed in f38302d

@danbev danbev closed this Jun 8, 2017
@danbev danbev deleted the make-IsConstructCall-constent branch June 8, 2017 08:47
addaleax pushed a commit that referenced this pull request Jun 10, 2017
@danbev @addaleax
src: make IsConstructCall checks consistent
dd158b0 
The most common way to perfom this check is by using the simple CHECK
macro. This commit suggest making this consistent in favour of the most
commonly used.

PR-URL: #13473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@addaleax addaleax mentioned this pull request Jun 10, 2017
Merged
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@danbev @MylesBorins
src: make IsConstructCall checks consistent
69143ff 
The most common way to perfom this check is by using the simple CHECK
macro. This commit suggest making this consistent in favour of the most
commonly used.

PR-URL: #13473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@danbev @bnoordhuis @jasnell @targos @cjihrig @mhdawson @MylesBorins @nodejs-github-bot