src: check whether inspector is doing io #13504

sam-github · 2017-06-06T18:24:44Z

Inspector start means that it exists, but doesn't mean it is listening
on a port, that only happens if it is doing I/O (i.e. has an io object).

Fixes: #13499

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

src,inspector

sam-github · 2017-06-06T22:00:13Z

ci: https://ci.nodejs.org/job/node-test-pull-request/8521/

refack · 2017-06-06T22:13:07Z

test/inspector/test-inspector-port-zero.js

@@ -46,3 +46,9 @@ test('--inspect=localhost:0');
 test('--inspect-brk=0');
 test('--inspect-brk=127.0.0.1:0');


@eugeneo can we have some of these in #13478?

I added some tests there

refack · 2017-06-06T22:15:35Z

test/inspector/test-inspector-port-zero.js

@@ -7,7 +7,7 @@ const assert = require('assert');
 const { URL } = require('url');
 const { spawn } = require('child_process');

-function test(arg) {
+function test(arg, expected) {


why not default arg port = ''

sam-github · 2017-06-06T22:20:49Z

@refack Thanks for your suggestion, it was a good one.

sam-github · 2017-06-06T22:24:46Z

ci: https://ci.nodejs.org/job/node-test-pull-request/8522/

bnoordhuis · 2017-06-07T10:13:09Z

src/node.cc

@@ -3059,7 +3059,7 @@ static void DebugPortGetter(Local<Name> property,
 #if HAVE_INSPECTOR
 if (port == 0) {
 Environment* env = Environment::GetCurrent(info);
- if (env->inspector_agent()->IsStarted())
+ if (env->inspector_agent()->io())


DRY: if (auto io = env->inspector_agent()->io()) port = io->port();?

Should it check io->IsStarted()? The inspector has a venerable multitude of IsStarted methods...

No. IsStarted() should be called IsInitialized(), and it always happens if the Agent was constructed, unless I very much misremember. I'll check again, but I'm pretty sure. And I agree, the word "start" in method names is a bit overused in node's c++ source.

yes, IsStarted() means its newed a NodeInspectorClient client_, its the io_ that means its listening on a port.

sam-github · 2017-06-08T21:55:30Z

I changed the C++, so ci again: https://ci.nodejs.org/job/node-test-pull-request/8565/

sam-github · 2017-06-09T15:01:34Z

OS X failed on

not ok 174 async-hooks/test-callback-error

@addaleax (in the absence of an at-nodejs/async-hooks)

AIX failed on

not ok 13 async-hooks/test-fseventwrap

@gireeshpunathil would you know anything about that?

Neither look related.

addaleax · 2017-06-09T15:06:10Z

OS X failed on

not ok 174 async-hooks/test-callback-error

@addaleax (in the absence of an at-nodejs/async-hooks)

we do have @nodejs/async_hooks ;) I don’t really know how that test would be flaky.

gibfahn · 2017-06-09T15:09:24Z

not ok 13 async-hooks/test-fseventwrap

#13577 was just raised, so I believe you're okay there.

sam-github · 2017-06-09T15:14:43Z

ci: https://ci.nodejs.org/job/node-test-pull-request/8578/ to see if the async hooks test always fails

gibfahn · 2017-06-09T15:36:24Z

not ok 174 async-hooks/test-callback-error

1000 runs on my machine (macOS sierra) with no failures, I think this is good to go.

AndreasMadsen · 2017-06-09T16:01:37Z

I don’t really know how that test would be flaky.

It is a real mystery. See: #13527

sam-github · 2017-06-09T16:10:27Z

OK, everything passed this time except for

not ok 1432 inspector/test-inspector-port-zero-cluster # TODO : Fix flaky test

on centos: https://ci.nodejs.org/job/node-test-commit-linux/10482/nodes=centos7-64/

Inspector start means that it exists, but doesn't mean it is listening on a port, that only happens if it is doing I/O (i.e. has an io object). PR-URL: nodejs#13504 Fixes: nodejs#13499 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gibfahn · 2017-06-09T16:26:14Z

not ok 1432 inspector/test-inspector-port-zero-cluster # TODO : Fix flaky test

Should really have fixed that flaky test before landing this @sam-github 😉

refack · 2017-06-09T16:49:23Z

not ok 174 async-hooks/test-callback-error

I don’t really know how that test would be flaky.

It is a real mystery. See: #13527

It just is 🤷‍♂️ (probably the process.abort taking too long)
#13559

Inspector start means that it exists, but doesn't mean it is listening on a port, that only happens if it is doing I/O (i.e. has an io object). PR-URL: #13504 Fixes: #13499 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 6, 2017

mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Jun 6, 2017

sam-github force-pushed the check-is-listening branch from ef98c6c to 29c4083 Compare June 6, 2017 21:59

refack reviewed Jun 6, 2017

View reviewed changes

sam-github mentioned this pull request Jun 6, 2017

inspector-port=0 edge case crash #13499

Closed

refack approved these changes Jun 6, 2017

View reviewed changes

bnoordhuis reviewed Jun 7, 2017

View reviewed changes

sam-github force-pushed the check-is-listening branch from a5dadff to b5ee5a2 Compare June 8, 2017 21:53

refack approved these changes Jun 8, 2017

View reviewed changes

cjihrig approved these changes Jun 9, 2017

View reviewed changes

sam-github force-pushed the check-is-listening branch from b5ee5a2 to c4a61b3 Compare June 9, 2017 16:11

sam-github merged commit c4a61b3 into nodejs:master Jun 9, 2017

sam-github deleted the check-is-listening branch June 9, 2017 16:13

addaleax mentioned this pull request Jun 10, 2017

v8.1.1 proposal #13598

Merged

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

MylesBorins added the dont-land-on-v6.x label Jul 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: check whether inspector is doing io #13504

src: check whether inspector is doing io #13504

sam-github commented Jun 6, 2017 •

edited

Loading

sam-github commented Jun 6, 2017

refack Jun 6, 2017

eugeneo Jun 6, 2017

refack Jun 6, 2017

sam-github commented Jun 6, 2017

sam-github commented Jun 6, 2017

bnoordhuis Jun 7, 2017

sam-github Jun 7, 2017

sam-github Jun 8, 2017

sam-github commented Jun 8, 2017

sam-github commented Jun 9, 2017

addaleax commented Jun 9, 2017

gibfahn commented Jun 9, 2017

sam-github commented Jun 9, 2017

gibfahn commented Jun 9, 2017

AndreasMadsen commented Jun 9, 2017

sam-github commented Jun 9, 2017

gibfahn commented Jun 9, 2017

refack commented Jun 9, 2017

		@@ -46,3 +46,9 @@ test('--inspect=localhost:0');
		test('--inspect-brk=0');
		test('--inspect-brk=127.0.0.1:0');

src: check whether inspector is doing io #13504

src: check whether inspector is doing io #13504

Conversation

sam-github commented Jun 6, 2017 • edited Loading

Checklist

Affected core subsystem(s)

sam-github commented Jun 6, 2017

refack Jun 6, 2017

Choose a reason for hiding this comment

eugeneo Jun 6, 2017

Choose a reason for hiding this comment

refack Jun 6, 2017

Choose a reason for hiding this comment

sam-github commented Jun 6, 2017

sam-github commented Jun 6, 2017

bnoordhuis Jun 7, 2017

Choose a reason for hiding this comment

sam-github Jun 7, 2017

Choose a reason for hiding this comment

sam-github Jun 8, 2017

Choose a reason for hiding this comment

sam-github commented Jun 8, 2017

sam-github commented Jun 9, 2017

addaleax commented Jun 9, 2017

gibfahn commented Jun 9, 2017

sam-github commented Jun 9, 2017

gibfahn commented Jun 9, 2017

AndreasMadsen commented Jun 9, 2017

sam-github commented Jun 9, 2017

gibfahn commented Jun 9, 2017

refack commented Jun 9, 2017

sam-github commented Jun 6, 2017 •

edited

Loading