doc: fix out of date sections in n-api doc #13508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Jun 6, 2017
cjihrig
approved these changes
Jun 6, 2017
jasongin
approved these changes
Jun 6, 2017
|
@mhdawson While you're on it, could you please take a look at #13469 (comment)? |
|
@RReverser since this PR is past the 48 hour wait and has been reviewed, I'd prefer to cover that one in the next set of changes. From our discussion today in the N-API I think there are another 3-4 ones that you have found that I can cover together. |
|
CI good landing. |
|
Landed as c28418a |
Merged
3 tasks
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
PR-URL: nodejs#13508 Fixes: nodejs#13469 Fixes: nodejs#13458 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13469
Fixes: #13458
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, n-api