Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: corrects reference to tlsClientError #13533

Closed
wants to merge 1 commit into from
Closed

doc: corrects reference to tlsClientError #13533

wants to merge 1 commit into from

Conversation

tarunbatra
Copy link
Contributor

@tarunbatra tarunbatra commented Jun 7, 2017 •
edited
Loading

After the renaming of clientError in TLS to tlsClientError in 1ab6b21,
the docs inconsistently referred the error as clientError, which is now
corrected.

It can be confirmed by looking at this line, the error generated on timeout is tlsClientError and not clientError, making the current doc wrong.

Fixes: #13417
PR-URL: #13533

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jun 7, 2017
@tarunbatra
doc: corrects reference to tlsClientError
5bf3b4f 
After the renaming of `clientError` in TLS to `tlsClientError` in
1ab6b21,
the docs inconsistently referred the error as `clientError`, which is now
corrected.

Fixes: #13417
PR-URL: #13533
@silverwind
Copy link
Contributor

Thanks! Landed in 597ba15.

@silverwind silverwind closed this Jun 8, 2017
silverwind pushed a commit that referenced this pull request Jun 8, 2017
@tarunbatra @silverwind
doc: corrects reference to tlsClientError
597ba15 
After the renaming of `clientError` in TLS to `tlsClientError` in
1ab6b21,
the docs inconsistently referred the error as `clientError`, which is now
corrected.

Fixes: #13417
PR-URL: #13533
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
addaleax pushed a commit that referenced this pull request Jun 10, 2017
@tarunbatra @addaleax
doc: corrects reference to tlsClientError
8c5407d 
After the renaming of `clientError` in TLS to `tlsClientError` in
1ab6b21,
the docs inconsistently referred the error as `clientError`, which is now
corrected.

Fixes: #13417
PR-URL: #13533
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@addaleax addaleax mentioned this pull request Jun 10, 2017
Merged
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@tarunbatra @MylesBorins
doc: corrects reference to tlsClientError
054f8cd 
After the renaming of `clientError` in TLS to `tlsClientError` in
1ab6b21,
the docs inconsistently referred the error as `clientError`, which is now
corrected.

Fixes: #13417
PR-URL: #13533
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tls, doc: documentation mentions unexisting clientError event
5 participants
@tarunbatra @silverwind @refack @MylesBorins @nodejs-github-bot