doc: fix links and typos in fs.md #13573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
We had exposed md code instead of links here: https://github.com/vsemozhetbyt/node/blame/47b9772f52aba7693eed4df535b35de65ac22c49/doc/api/fs.md#L1731 And a wrong hash here: |
cjihrig
approved these changes
Jun 9, 2017
tniessen
reviewed
Jun 9, 2017
doc/api/fs.md
Outdated
| @@ -1767,7 +1767,7 @@ changes: | |||
| * `encoding` {string|null} default = `null` | |||
| * `flag` {string} default = `'r'` | |||
|
|
|||
| Synchronous version of [`fs.readFile`][]. Returns the contents of the `file`. | |||
| Synchronous version of [`fs.readFile()`][]. Returns the contents of the `file`. | |||
There was a problem hiding this comment.
Doesn't make sense to me why file is highlighted as code even though there is no parameter with that name. I know it's unrelated to this PR, but maybe you would like to fix it while you are at it :)
There was a problem hiding this comment.
Done for this and 2 other places. It seems these typos are from the same source as the link issues.
vsemozhetbyt
changed the title
jasnell
approved these changes
Jun 9, 2017
lpinca
approved these changes
Jun 10, 2017
|
Landed in e2617a0 |
vsemozhetbyt
added a commit
that referenced
this pull request
Jun 12, 2017
PR-URL: #13573 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 12, 2017
PR-URL: #13573 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, fs